third_party/WebKit/Source/platform/CrossThreadCopier.h - Issue 1999343002: Unify and provide one IsGarbageCollectedType<T> implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/CrossThreadCopier.h

Issue 1999343002: Unify and provide one IsGarbageCollectedType<T> implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unit test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp ('k') | third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/CrossThreadCopier.h

diff --git a/third_party/WebKit/Source/platform/CrossThreadCopier.h b/third_party/WebKit/Source/platform/CrossThreadCopier.h

index a3fce4a8e779dd938613b67bb69382d93539edba..863371ae5b1c04318b86a1245d925f2d33cc2910 100644

--- a/third_party/WebKit/Source/platform/CrossThreadCopier.h

+++ b/third_party/WebKit/Source/platform/CrossThreadCopier.h

@@ -253,7 +253,7 @@ struct CrossThreadCopier<AllowCrossThreadAccessWrapper<T>> {

template <typename T>

AllowCrossThreadAccessWrapper<T*> AllowCrossThreadAccess(T* value)

{

- static_assert(!blink::IsGarbageCollectedType<T>::value, "Use wrapCrossThreadPersistent() instead for garbage-collected pointers");

+ static_assert(!IsGarbageCollectedType<T>::value, "Use wrapCrossThreadPersistent() instead for garbage-collected pointers");

static_assert(!WTF::IsSubclassOfTemplate<T, ThreadSafeRefCounted>::value, "Use PassRefPtr<T> instead for ThreadSafeRefCounted");

return AllowCrossThreadAccessWrapper<T*>(value);

}