Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1999363002: Split out Members, Persistents and SelfKeepAlive in separate headers. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, tyoshino+watch_chromium.org, oilpan-reviews, Mads Ager (chromium), mlamouri+watch-blink_chromium.org, blink-reviews-css, dcheng, loading-reviews_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, gavinp+loader_chromium.org, darktears, blink-reviews, blink-reviews-bindings_chromium.org, kinuko+watch, Nate Chapin, kouhei+heap_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@sof-gc-type
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split out Members, Persistents and SelfKeepAlive in separate headers. Complete the migration of definitions out of Handle.h, adding new header files for the family of Member<> types that Oilpan supports. Similarly for Persistent<> and its variants, and the SelfKeepAlive<> abstraction. To further prune Handle.h, let go of the unused ScopedDisposal (light) abstraction. R= BUG= Committed: https://crrev.com/3e5bcb132b1af136ba6faa1c152dcba2c298549f Cr-Commit-Position: refs/heads/master@{#395318}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+448 lines, -1616 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageGeneratorValue.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Handle.h View 2 3 chunks +2 lines, -1116 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 2 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/heap/Member.h View 1 chunk +328 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/heap/Persistent.h View 2 4 chunks +18 lines, -494 lines 0 comments Download
A third_party/WebKit/Source/platform/heap/SelfKeepAlive.h View 1 chunk +83 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/blink_heap.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/SuspendableScriptExecutor.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-22 14:43:20 UTC) #2
haraken
I'm fine with this change but is there any reason you want to split out ...
4 years, 7 months ago (2016-05-22 14:46:53 UTC) #3
sof
On 2016/05/22 14:46:53, haraken wrote: > I'm fine with this change but is there any ...
4 years, 7 months ago (2016-05-22 15:01:13 UTC) #4
haraken
On 2016/05/22 15:01:13, sof wrote: > On 2016/05/22 14:46:53, haraken wrote: > > I'm fine ...
4 years, 7 months ago (2016-05-23 01:23:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999363002/40001
4 years, 7 months ago (2016-05-23 07:04:00 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233628)
4 years, 7 months ago (2016-05-23 09:32:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999363002/40001
4 years, 7 months ago (2016-05-23 10:39:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999363002/40001
4 years, 7 months ago (2016-05-23 13:08:13 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-23 14:28:27 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 14:30:26 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3e5bcb132b1af136ba6faa1c152dcba2c298549f
Cr-Commit-Position: refs/heads/master@{#395318}

Powered by Google App Engine
This is Rietveld 408576698