Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 1998863002: QUIC - added disable_delay_tcp_race field trial param to disable delaying of racing TCP connection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase with TOT - moved the code to components Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/network_session_configurator/network_session_configurator_unittest.cc
diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/network_session_configurator_unittest.cc
index a2dc72fa9129ba07bcd11041d34b29a8d6b7792b..bcc14ee319f99d81199f5b3d7da025fd0904ade4 100644
--- a/components/network_session_configurator/network_session_configurator_unittest.cc
+++ b/components/network_session_configurator/network_session_configurator_unittest.cc
@@ -218,6 +218,7 @@ TEST_F(NetworkSessionConfiguratorTest, EnableQuicFromFieldTrialGroup) {
EXPECT_FALSE(params_.enable_alternative_service_with_different_host);
EXPECT_EQ(0, params_.quic_max_number_of_lossy_connections);
EXPECT_EQ(1.0f, params_.quic_packet_loss_threshold);
+ EXPECT_TRUE(params_.quic_delay_tcp_race);
EXPECT_FALSE(params_.quic_close_sessions_on_ip_change);
EXPECT_EQ(net::kIdleConnectionTimeoutSeconds,
params_.quic_idle_connection_timeout_seconds);
@@ -562,6 +563,17 @@ TEST_F(NetworkSessionConfiguratorTest, QuicReceiveBufferSize) {
EXPECT_EQ(2097152, params_.quic_socket_receive_buffer_size);
}
+TEST_F(NetworkSessionConfiguratorTest, QuicDisableDelayTcpRace) {
+ std::map<std::string, std::string> field_trial_params;
+ field_trial_params["disable_delay_tcp_race"] = "true";
+ variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
+ base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
+
+ ParseFieldTrials();
+
+ EXPECT_FALSE(params_.quic_delay_tcp_race);
+}
+
TEST_F(NetworkSessionConfiguratorTest, QuicOriginsToForceQuicOn) {
base::CommandLine::ForCurrentProcess()->AppendSwitch("enable-quic");
base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698