QUIC - added disable_delay_tcp_race field trial param to disable delaying of racing TCP connection

chrome/browser/io_thread.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/io_thread.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/base64.h"
@@ skipping 1433 matching lines @@
                                           "receive_buffer_size"),
                         &value)) {
     return value;
   }
   return 0;
 }
 
 // static
 bool IOThread::NetworkSessionConfigurator::ShouldQuicDelayTcpRace(
     const VariationParameters& quic_trial_params) {
-  return base::LowerCaseEqualsASCII(
-      GetVariationParam(quic_trial_params, "delay_tcp_race"), "true");
+  std::string delay_tcp_race = GetVariationParam(quic_trial_params,

[ramant (doing other things), 2016/05/20 00:00:49]

Hi Ryan,
  Another option is to rename this parameter to "disable_delay_tcp_race" and
change all the code accordingly. What do you think?

thanks
raman

[Ryan Hamilton, 2016/05/20 03:17:27]

Yeah, it seems like that would be a better idea.

[ramant (doing other things), 2016/05/24 16:52:02]

Done.

+                                                 "delay_tcp_race");
+  // If "delay_tcp_race" parameter is not set, then default it to the default
+  // value which is true. Otherwise, if it is set, then return the value set by
+  // the parameter.
+  return delay_tcp_race.empty() || base::LowerCaseEqualsASCII(delay_tcp_race,
+                                                              "true");
 }
 
 // static
 bool IOThread::NetworkSessionConfigurator::ShouldQuicCloseSessionsOnIpChange(
     const VariationParameters& quic_trial_params) {
   return base::LowerCaseEqualsASCII(
       GetVariationParam(quic_trial_params, "close_sessions_on_ip_change"),
       "true");
 }
 
@@ skipping 241 matching lines @@
   // TODO(rtenneti): We should probably use HttpServerPropertiesManager for the
   // system URLRequestContext too. There's no reason this should be tied to a
   // profile.
   return context;
 }
 
 const metrics::UpdateUsagePrefCallbackType&
 IOThread::GetMetricsDataUseForwarder() {
   return metrics_data_use_forwarder_;
 }