Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1998603002: Make VM resolvePackageUri fail on package:foo and package:/foo. (Closed)

Created:
4 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 6 months ago
Reviewers:
floitsch, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move to new file. #

Patch Set 3 : Reenable test blocked by change #

Patch Set 4 : Do allow package:foo.dart with a package root. Update tests to match. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M runtime/bin/vmservice/loader.dart View 1 2 3 5 chunks +20 lines, -13 lines 0 comments Download
M tests/isolate/isolate.status View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/packages_file_test.dart View 1 2 3 9 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Lasse Reichstein Nielsen
https://codereview.chromium.org/1998603002/diff/1/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/1998603002/diff/1/runtime/bin/builtin.dart#newcode288 runtime/bin/builtin.dart:288: "'package:packageName${uri.path}', not 'package:${uri.path}'"; This case wasn't handled before, but ...
4 years, 7 months ago (2016-05-19 10:55:26 UTC) #1
Lasse Reichstein Nielsen
4 years, 6 months ago (2016-05-27 08:12:33 UTC) #3
mit
On 2016/05/27 08:12:33, Lasse Reichstein Nielsen wrote: Florian & Siva, friendly ping to get this ...
4 years, 6 months ago (2016-05-31 07:50:09 UTC) #4
floitsch
LGTM.
4 years, 6 months ago (2016-05-31 09:40:40 UTC) #5
Lasse Reichstein Nielsen
Ping. This change is basically ready to land, so I just need to know if ...
4 years, 6 months ago (2016-06-13 10:11:43 UTC) #6
siva
lgtm
4 years, 6 months ago (2016-06-14 01:00:19 UTC) #7
Lasse Reichstein Nielsen
Committed patchset #3 (id:40001) manually as eb49613cbfaca2167b124ab01064a2412ff844a5 (presubmit successful).
4 years, 6 months ago (2016-06-14 07:39:17 UTC) #9
Lasse Reichstein Nielsen
4 years, 6 months ago (2016-06-14 10:22:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
191ab42d64b41164f0d6a9588ba73603a331086f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698