Make VM resolvePackageUri fail on package:foo and package:/foo.

tests/standalone/packages_file_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "dart:async";
 import "dart:io";
 import "dart:convert" show JSON;
 import "package:path/path.dart" as p;
 import "package:async_helper/async_helper.dart";
 
@@ skipping 278 matching lines @@
     // value of these, you can only change what value to expect.
     // For values not included here (commented out), the result is not tested
     // unless a value (maybe null) is provided.
     fixPaths(expect);
 
     expect = {
       "pconf":    null,
       "proot":    null,
       "iconf":    null,
       "iroot":    null,
-      // "foo":     null,
+      "foo":      null,
       "foo/":     null,
       "foo/bar":  null,
       "foo.x":    "qux",
       "bar/bar":  null,
       "relative": "relative/path",
       "nonpkg":   "http://example.org/file"
     }..addAll(expect ?? const {});
 
     // Add http files to the http server.
     if (http.isNotEmpty) {
@@ skipping 36 matching lines @@
       // No parameters, no .packages files or packages/ dir.
       // A "file:" source realizes there is no configuration and can't resolve
       // any packages, but a "http:" source assumes a "packages/" directory.
       addScheme("no resolution",
         "%$scheme/",
         files: {},
         expect: (scheme == "file") ? {
           "foo.x": null
         } : {
           "iroot": "%http/packages/",
+          "foo": "%http/packages/foo",
           "foo/": "%http/packages/foo/",
           "foo/bar": "%http/packages/foo/bar",
           "foo.x": null,
           "bar/bar": "%http/packages/bar/bar",
         });
     }
 
     {
       // No parameters, no .packages files,
       // packages/ dir exists and is detected.
       var files = {"packages": fooPackage};
       addScheme("implicit packages dir","%$scheme/",
         files: files,
         expect: {
           "iroot": "%$scheme/packages/",
+          "foo": "%$scheme/packages/foo",
           "foo/": "%$scheme/packages/foo/",
           "foo/bar": "%$scheme/packages/foo/bar",
           "bar/bar": "%$scheme/packages/bar/bar",
         });
     }
 
     {
       // No parameters, no .packages files in current dir, but one in parent,
       // packages/ dir exists and is used.
       //
       // Should not detect the .packages file in parent directory.
       // That file is empty, so if it is used, the system cannot resolve "foo".
       var files = {"sub": {"packages": fooPackage},
                    ".packages": ""};
       addScheme("implicit packages dir overrides parent .packages",
         "%$scheme/sub/",
         files: files,
         expect: {
           "iroot": "%$scheme/sub/packages/",
+          "foo": "%$scheme/sub/packages/foo",
           "foo/": "%$scheme/sub/packages/foo/",
           "foo/bar": "%$scheme/sub/packages/foo/bar",
           // "foo.x": "qux",  // Blocked by issue http://dartbug.com/26482
           "bar/bar": "%$scheme/sub/packages/bar/bar",
         });
     }
 
     {
       // No parameters, a .packages file next to entry is found and used.
       // A packages/ directory is ignored.
@@ skipping 17 matching lines @@
                    ".packages": "foo:pkgs/foo/",
                    "pkgs": fooPackage};
       addScheme(".packages file in parent", "%$scheme/sub/",
         files: files,
         expect: (scheme == "file") ? {
           "iconf": "%file/.packages",
           "foo/": "%file/pkgs/foo/",
           "foo/bar": "%file/pkgs/foo/bar",
         } : {
           "iroot": "%http/sub/packages/",
+          "foo": "%http/sub/packages/foo",
           "foo/": "%http/sub/packages/foo/",
           "foo/bar": "%http/sub/packages/foo/bar",
           "foo.x": null,
           "bar/bar": "%http/sub/packages/bar/bar",
         });
     }
 
     {
       // Specified package root that doesn't exist.
       // Ignores existing .packages file and packages/ dir.
       addScheme("explicit root not there",
         "%$scheme/",
         files: {"packages": fooPackage,
                 ".packages": "foo:%$scheme/packages/"},
         root: "%$scheme/notthere/",
         expect: {
           "proot": "%$scheme/notthere/",
           "iroot": "%$scheme/notthere/",
+          "foo": "%$scheme/notthere/foo",
           "foo/": "%$scheme/notthere/foo/",
           "foo/bar": "%$scheme/notthere/foo/bar",
           "foo.x": null,
           "bar/bar": "%$scheme/notthere/bar/bar",
         });
     }
 
     {
       // Specified package config that doesn't exist.
       // Ignores existing .packages file and packages/ dir.
@@ skipping 16 matching lines @@
       // The Platform.packageRoot and Isolate.packageRoot has a trailing slash.
       var files = {".packages": "foo:packages/foo/",
                    "packages": {},
                    "pkgs": fooPackage};
       addScheme("explicit package root, no slash", "%$scheme/",
         files: files,
         root: "%$scheme/pkgs",
         expect: {
           "proot": "%$scheme/pkgs/",
           "iroot": "%$scheme/pkgs/",
+          "foo": "%$scheme/pkgs/foo",
           "foo/": "%$scheme/pkgs/foo/",
           "foo/bar": "%$scheme/pkgs/foo/bar",
           "bar/bar": "%$scheme/pkgs/bar/bar",
         });
     }
 
     {
       // Specified package root with trailing slash.
       var files = {".packages": "foo:packages/foo/",
                    "packages": {},
                    "pkgs": fooPackage};
       addScheme("explicit package root, slash", "%$scheme/",
         files: files,
         root: "%$scheme/pkgs",
         expect: {
           "proot": "%$scheme/pkgs/",
           "iroot": "%$scheme/pkgs/",
+          "foo": "%$scheme/pkgs/foo",
           "foo/": "%$scheme/pkgs/foo/",
           "foo/bar": "%$scheme/pkgs/foo/bar",
           "bar/bar": "%$scheme/pkgs/bar/bar",
         });
     }
 
     {
       // Specified package config.
       var files = {".packages": "foo:packages/foo/",
                    "packages": {},
@@ skipping 40 matching lines @@
         var files = {};
         var https = {};
         (entryScheme == "file" ? files : https)["main"] = testMain;
         (pkgScheme == "file" ? files : https)["pkgs"] = fooPackage;
         add("$pkgScheme pkg/$entryScheme main", "%$entryScheme/",
           file: files, http: https,
           root: "%$pkgScheme/pkgs/",
           expect: {
             "proot": "%$pkgScheme/pkgs/",
             "iroot": "%$pkgScheme/pkgs/",
+            "foo": "%$pkgScheme/pkgs/foo",
             "foo/": "%$pkgScheme/pkgs/foo/",
             "foo/bar": "%$pkgScheme/pkgs/foo/bar",
             "bar/bar": "%$pkgScheme/pkgs/bar/bar",
             "foo.x": "qux",
           });
       }
       // Package config. The configuration file may also be on either source.
       for (var configScheme in const ["file", "http"]) {
         // Don't do the boring stuff!
         if (entryScheme == configScheme && entryScheme == pkgScheme) continue;
@@ skipping 416 matching lines @@
 void insertFileAt(Map file, Map http,
                   String path, String name, String content) {
   var parts = path.split('/').toList();
   var dir = (parts[0] == "%file") ? file : http;
   for (var i = 1; i < parts.length - 1; i++) {
     var entry = parts[i];
     dir = dir[entry] ?? (dir[entry] = {});
   }
   dir[name] = content;
 }