Make VM resolvePackageUri fail on package:foo and package:/foo.

runtime/bin/builtin.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library builtin;
 // NOTE: Do not import 'dart:io' in builtin.
 import 'dart:async';
 import 'dart:collection';
 import 'dart:_internal';
 import 'dart:isolate';
@@ skipping 250 matching lines @@
   // sets up the package root. Automatically discovered package root will
   // not update the VMLibraryHooks value.
   VMLibraryHooks.packageRootString = _packageRoot.toString();
   if (_traceLoading) {
     _log('Package root URI: $_packageRoot');
   }
 }
 
 
 // Given a uri with a 'package' scheme, return a Uri that is prefixed with
-// the package root.
+// the package root or resolved relative to the package configuration.
 Uri _resolvePackageUri(Uri uri) {
   assert(uri.scheme == "package");
   assert(_packagesReady);
 
-  if (!uri.host.isEmpty) {
+  if (uri.host.isNotEmpty) {
     var path = '${uri.host}${uri.path}';
     var right = 'package:$path';
     var wrong = 'package://$path';
 
     throw "URIs using the 'package:' scheme should look like "
           "'$right', not '$wrong'.";
   }
-
+  var packageNameEnd = uri.path.indexOf('/');
+  if (packageNameEnd == 0) {
+    // Package URIs must have a non-empty package name (not start with "/").
+    throw "URIS using the 'package:' scheme should look like "
+          "'package:packageName${uri.path}', not 'package:${uri.path}'";

[Lasse Reichstein Nielsen, 2016/05/19 10:55:25]

This case wasn't handled before, but with a package root, it created a
completely wrong result.

+  }
+  if (packageNameEnd < 0) {
+    // Package URIs must have a path after the package name, even if it's
+    // just "/".
+    throw "URIS using the 'package:' scheme should look like "
+          "'package:${uri.path}/', not 'package:${uri.path}'";
+  }
   if (_traceLoading) {
     _log('Resolving package with uri path: ${uri.path}');
   }
   var resolvedUri;
   if (_packageError != null) {
     if (_traceLoading) {
       _log("Resolving package with pending resolution error: $_packageError");
     }
     throw _packageError;
   } else if (_packageRoot != null) {
     resolvedUri = _packageRoot.resolve(uri.path);
   } else {
-    var packageName = uri.pathSegments[0];
+    var packageName = uri.path.substring(0, packageNameEnd);
     var mapping = _packageMap[packageName];
     if (_traceLoading) {
       _log("Mapped '$packageName' package to '$mapping'");
     }
     if (mapping == null) {
       throw "No mapping for '$packageName' package when resolving '$uri'.";
     }
     var path;
-    if (uri.path.length > packageName.length) {
-      path = uri.path.substring(packageName.length + 1);
-    } else {
-      // Handle naked package resolution to the default package name:
-      // package:foo is equivalent to package:foo/foo.dart
-      assert(uri.path.length == packageName.length);
-      path = "$packageName.dart";
-    }
+    assert(uri.path.length > packageName.length);
+    path = uri.path.substring(packageName.length + 1);
     if (_traceLoading) {
       _log("Path to be resolved in package: $path");
     }
     resolvedUri = mapping.resolve(path);
   }
   if (_traceLoading) {
     _log("Resolved '$uri' to '$resolvedUri'.");
   }
   return resolvedUri;
 }
@@ skipping 581 matching lines @@
 
 // Register callbacks and hooks with the rest of the core libraries.
 _setupHooks() {
   _setupCompleted = true;
   VMLibraryHooks.resourceReadAsBytes = _resourceReadAsBytes;
 
   VMLibraryHooks.packageRootUriFuture = _getPackageRootFuture;
   VMLibraryHooks.packageConfigUriFuture = _getPackageConfigFuture;
   VMLibraryHooks.resolvePackageUriFuture = _resolvePackageUriFuture;
 }