Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: tests/standalone/packages_file_test.dart

Issue 1998603002: Make VM resolvePackageUri fail on package:foo and package:/foo. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Do allow package:foo.dart with a package root. Update tests to match. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/isolate/isolate.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/packages_file_test.dart
diff --git a/tests/standalone/packages_file_test.dart b/tests/standalone/packages_file_test.dart
index 66310f36b92348c373b986618b3a61906370f77f..9902d69f6a757faadb461ff8d809ccb9dd723b57 100644
--- a/tests/standalone/packages_file_test.dart
+++ b/tests/standalone/packages_file_test.dart
@@ -296,7 +296,7 @@ void createConfigurations() {
"proot": null,
"iconf": null,
"iroot": null,
- // "foo": null,
+ "foo": null,
"foo/": null,
"foo/bar": null,
"foo.x": "qux",
@@ -353,6 +353,7 @@ void createConfigurations() {
"foo.x": null
} : {
"iroot": "%http/packages/",
+ "foo": "%http/packages/foo",
"foo/": "%http/packages/foo/",
"foo/bar": "%http/packages/foo/bar",
"foo.x": null,
@@ -368,6 +369,7 @@ void createConfigurations() {
files: files,
expect: {
"iroot": "%$scheme/packages/",
+ "foo": "%$scheme/packages/foo",
"foo/": "%$scheme/packages/foo/",
"foo/bar": "%$scheme/packages/foo/bar",
"bar/bar": "%$scheme/packages/bar/bar",
@@ -387,6 +389,7 @@ void createConfigurations() {
files: files,
expect: {
"iroot": "%$scheme/sub/packages/",
+ "foo": "%$scheme/sub/packages/foo",
"foo/": "%$scheme/sub/packages/foo/",
"foo/bar": "%$scheme/sub/packages/foo/bar",
// "foo.x": "qux", // Blocked by issue http://dartbug.com/26482
@@ -424,6 +427,7 @@ void createConfigurations() {
"foo/bar": "%file/pkgs/foo/bar",
} : {
"iroot": "%http/sub/packages/",
+ "foo": "%http/sub/packages/foo",
"foo/": "%http/sub/packages/foo/",
"foo/bar": "%http/sub/packages/foo/bar",
"foo.x": null,
@@ -442,6 +446,7 @@ void createConfigurations() {
expect: {
"proot": "%$scheme/notthere/",
"iroot": "%$scheme/notthere/",
+ "foo": "%$scheme/notthere/foo",
"foo/": "%$scheme/notthere/foo/",
"foo/bar": "%$scheme/notthere/foo/bar",
"foo.x": null,
@@ -478,6 +483,7 @@ void createConfigurations() {
expect: {
"proot": "%$scheme/pkgs/",
"iroot": "%$scheme/pkgs/",
+ "foo": "%$scheme/pkgs/foo",
"foo/": "%$scheme/pkgs/foo/",
"foo/bar": "%$scheme/pkgs/foo/bar",
"bar/bar": "%$scheme/pkgs/bar/bar",
@@ -495,6 +501,7 @@ void createConfigurations() {
expect: {
"proot": "%$scheme/pkgs/",
"iroot": "%$scheme/pkgs/",
+ "foo": "%$scheme/pkgs/foo",
"foo/": "%$scheme/pkgs/foo/",
"foo/bar": "%$scheme/pkgs/foo/bar",
"bar/bar": "%$scheme/pkgs/bar/bar",
@@ -555,6 +562,7 @@ void createConfigurations() {
expect: {
"proot": "%$pkgScheme/pkgs/",
"iroot": "%$pkgScheme/pkgs/",
+ "foo": "%$pkgScheme/pkgs/foo",
"foo/": "%$pkgScheme/pkgs/foo/",
"foo/bar": "%$pkgScheme/pkgs/foo/bar",
"bar/bar": "%$pkgScheme/pkgs/bar/bar",
« no previous file with comments | « tests/isolate/isolate.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698