Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 199763002: Verify FormatType in ScopedClipboardWriter::WritePickledData. (Closed)

Created:
6 years, 9 months ago by dcheng
Modified:
6 years, 9 months ago
Reviewers:
tony, sky
CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org, inferno
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update Android too #

Patch Set 3 : Rebase #

Patch Set 4 : Be less clever for GTK #

Patch Set 5 : Hack #

Patch Set 6 : Build fixes #

Patch Set 7 : Build fixes #

Patch Set 8 : Sigh #

Patch Set 9 : Windows #

Patch Set 10 : Fix Linux GTK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -51 lines) Patch
M chrome/browser/bookmarks/bookmark_node_data.h View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_node_data.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_node_data_views.cc View 3 chunks +3 lines, -14 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/clipboard/clipboard.h View 3 chunks +5 lines, -3 lines 0 comments Download
M ui/base/clipboard/clipboard.cc View 1 2 3 4 5 3 chunks +31 lines, -0 lines 0 comments Download
M ui/base/clipboard/clipboard_android.cc View 1 2 3 4 5 6 7 3 chunks +9 lines, -3 lines 0 comments Download
M ui/base/clipboard/clipboard_aura.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/base/clipboard/clipboard_aurax11.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/base/clipboard/clipboard_gtk.cc View 1 2 3 4 5 6 7 8 9 3 chunks +9 lines, -3 lines 0 comments Download
M ui/base/clipboard/clipboard_mac.mm View 1 2 3 4 5 6 7 3 chunks +11 lines, -3 lines 0 comments Download
M ui/base/clipboard/clipboard_win.cc View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/clipboard/scoped_clipboard_writer.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcheng
6 years, 9 months ago (2014-03-14 01:16:18 UTC) #1
dcheng
Updated with a horrible hack to force instantiation of the web and pepper custom types ...
6 years, 9 months ago (2014-03-14 01:38:32 UTC) #2
tony
LGTM We can cleanup and write a test in a follow up change.
6 years, 9 months ago (2014-03-14 01:39:59 UTC) #3
dcheng
TBR sky for the bookmark changes.
6 years, 9 months ago (2014-03-14 02:49:04 UTC) #4
dcheng
Committed patchset #9 manually as r256974 (tree was closed).
6 years, 9 months ago (2014-03-14 02:49:23 UTC) #5
dcheng
6 years, 9 months ago (2014-03-14 03:16:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #10 manually as r256981 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698