Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: ui/base/clipboard/clipboard_gtk.cc

Issue 199763002: Verify FormatType in ScopedClipboardWriter::WritePickledData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Linux GTK Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/clipboard/clipboard_aurax11.cc ('k') | ui/base/clipboard/clipboard_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/clipboard/clipboard_gtk.cc
diff --git a/ui/base/clipboard/clipboard_gtk.cc b/ui/base/clipboard/clipboard_gtk.cc
index 8f819113ac408eacad5f1104d72dc935053e4821..fddd86b8ab17221bf724b7086f1354c478a95059 100644
--- a/ui/base/clipboard/clipboard_gtk.cc
+++ b/ui/base/clipboard/clipboard_gtk.cc
@@ -202,6 +202,10 @@ Clipboard::FormatType Clipboard::FormatType::Deserialize(
return FormatType(serialization);
}
+bool Clipboard::FormatType::operator<(const FormatType& other) const {
+ return GdkAtomToString(data_) < GdkAtomToString(other.data_);
+}
+
bool Clipboard::FormatType::Equals(const FormatType& other) const {
return data_ == other.data_;
}
@@ -592,7 +596,7 @@ uint64 Clipboard::GetSequenceNumber(ClipboardType type) {
}
//static
-Clipboard::FormatType Clipboard::GetFormatType(
+Clipboard::FormatType Clipboard::GetFormatTypeInternal(
const std::string& format_string) {
return FormatType::Deserialize(format_string);
}
@@ -645,13 +649,15 @@ const Clipboard::FormatType& Clipboard::GetWebKitSmartPasteFormatType() {
// static
const Clipboard::FormatType& Clipboard::GetWebCustomDataFormatType() {
- CR_DEFINE_STATIC_LOCAL(FormatType, type, (kMimeTypeWebCustomData));
+ CR_DEFINE_STATIC_LOCAL(
+ FormatType, type, (GetFormatType(kMimeTypeWebCustomData)));
return type;
}
// static
const Clipboard::FormatType& Clipboard::GetPepperCustomDataFormatType() {
- CR_DEFINE_STATIC_LOCAL(FormatType, type, (kMimeTypePepperCustomData));
+ CR_DEFINE_STATIC_LOCAL(
+ FormatType, type, (GetFormatType(kMimeTypePepperCustomData)));
return type;
}
« no previous file with comments | « ui/base/clipboard/clipboard_aurax11.cc ('k') | ui/base/clipboard/clipboard_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698