Verify FormatType in ScopedClipboardWriter::WritePickledData.

chrome/browser/bookmarks/bookmark_node_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/bookmarks/bookmark_node_data.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/pickle.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "ui/base/clipboard/scoped_clipboard_writer.h"
 
-const char* BookmarkNodeData::kClipboardFormatString =
-    "chromium/x-bookmark-entries";
-
 BookmarkNodeData::Element::Element() : is_url(false), id_(0) {
 }
 
 BookmarkNodeData::Element::Element(const BookmarkNode* node)
     : is_url(node->is_url()),
       url(node->url()),
       title(node->GetTitle()),
       date_added(node->date_added()),
       date_folder_modified(node->date_folder_modified()),
       id_(node->id()) {
@@ skipping 61 matching lines @@
       children.push_back(Element());
       if (!children.back().ReadFromPickle(pickle, iterator))
         return false;
     }
   }
   return true;
 }
 
 // BookmarkNodeData -----------------------------------------------------------
 
+// static
+const ui::Clipboard::FormatType& BookmarkNodeData::GetFormatType() {
+  CR_DEFINE_STATIC_LOCAL(
+      ui::Clipboard::FormatType,
+      type,
+      (ui::Clipboard::GetFormatType("chromium/x-bookmark-entries")));
+  return type;
+}
+
 BookmarkNodeData::BookmarkNodeData() {
 }
 
 BookmarkNodeData::BookmarkNodeData(const BookmarkNode* node) {
   elements.push_back(Element(node));
 }
 
 BookmarkNodeData::BookmarkNodeData(
     const std::vector<const BookmarkNode*>& nodes) {
   ReadFromVector(nodes);
 }
 
 BookmarkNodeData::~BookmarkNodeData() {
 }
 
 #if !defined(OS_MACOSX)
 // static
 bool BookmarkNodeData::ClipboardContainsBookmarks() {
   return ui::Clipboard::GetForCurrentThread()->IsFormatAvailable(
-      ui::Clipboard::GetFormatType(kClipboardFormatString),
+      GetFormatType(),
       ui::CLIPBOARD_TYPE_COPY_PASTE);
 }
 #endif
 
 bool BookmarkNodeData::ReadFromVector(
     const std::vector<const BookmarkNode*>& nodes) {
   Clear();
 
   if (nodes.empty())
     return false;
@@ skipping 41 matching lines @@
     // Also write the URL to the clipboard as text so that it can be pasted
     // into text fields. We use WriteText instead of WriteURL because we don't
     // want to clobber the X clipboard when the user copies out of the omnibox
     // on Linux (on Windows and Mac, there is no difference between these
     // functions).
     scw.WriteText(base::UTF8ToUTF16(url));
   }
 
   Pickle pickle;
   WriteToPickle(NULL, &pickle);
-  scw.WritePickledData(pickle,
-                       ui::Clipboard::GetFormatType(kClipboardFormatString));
+  scw.WritePickledData(pickle, GetFormatType());
 }
 
 bool BookmarkNodeData::ReadFromClipboard(ui::ClipboardType type) {
   DCHECK_EQ(type, ui::CLIPBOARD_TYPE_COPY_PASTE);
   std::string data;
   ui::Clipboard* clipboard = ui::Clipboard::GetForCurrentThread();
-  clipboard->ReadData(ui::Clipboard::GetFormatType(kClipboardFormatString),
-                      &data);
+  clipboard->ReadData(GetFormatType(), &data);
 
   if (!data.empty()) {
     Pickle pickle(data.data(), data.size());
     if (ReadFromPickle(&pickle))
       return true;
   }
 
   base::string16 title;
   std::string url;
   clipboard->ReadBookmark(&title, &url);
@@ skipping 72 matching lines @@
   DCHECK(profile_path_.empty());
 
   if (profile)
     profile_path_ = profile->GetPath();
 }
 
 bool BookmarkNodeData::IsFromProfile(Profile* profile) const {
   // An empty path means the data is not associated with any profile.
   return !profile_path_.empty() && profile_path_ == profile->GetPath();
 }