Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: chrome/browser/bookmarks/bookmark_node_data_views.cc

Issue 199763002: Verify FormatType in ScopedClipboardWriter::WritePickledData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Linux GTK Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_node_data_views.cc
diff --git a/chrome/browser/bookmarks/bookmark_node_data_views.cc b/chrome/browser/bookmarks/bookmark_node_data_views.cc
index 87b8cb4936fd8ab19a707ce1cdfd1cae6615dc4f..19a63ee704eb21549cc1c8b3eb0cddd3fc27105e 100644
--- a/chrome/browser/bookmarks/bookmark_node_data_views.cc
+++ b/chrome/browser/bookmarks/bookmark_node_data_views.cc
@@ -10,17 +10,6 @@
#include "content/public/common/url_constants.h"
#include "ui/base/clipboard/clipboard.h"
-// static
-const ui::OSExchangeData::CustomFormat&
-BookmarkNodeData::GetBookmarkCustomFormat() {
- CR_DEFINE_STATIC_LOCAL(
- ui::OSExchangeData::CustomFormat,
- format,
- (ui::Clipboard::GetFormatType(BookmarkNodeData::kClipboardFormatString)));
-
- return format;
-}
-
void BookmarkNodeData::Write(Profile* profile, ui::OSExchangeData* data) const {
DCHECK(data);
@@ -37,7 +26,7 @@ void BookmarkNodeData::Write(Profile* profile, ui::OSExchangeData* data) const {
Pickle data_pickle;
WriteToPickle(profile, &data_pickle);
- data->SetPickledData(GetBookmarkCustomFormat(), data_pickle);
+ data->SetPickledData(GetFormatType(), data_pickle);
}
bool BookmarkNodeData::Read(const ui::OSExchangeData& data) {
@@ -45,9 +34,9 @@ bool BookmarkNodeData::Read(const ui::OSExchangeData& data) {
profile_path_.clear();
- if (data.HasCustomFormat(GetBookmarkCustomFormat())) {
+ if (data.HasCustomFormat(GetFormatType())) {
Pickle drag_data_pickle;
- if (data.GetPickledData(GetBookmarkCustomFormat(), &drag_data_pickle)) {
+ if (data.GetPickledData(GetFormatType(), &drag_data_pickle)) {
if (!ReadFromPickle(&drag_data_pickle))
return false;
}
« no previous file with comments | « chrome/browser/bookmarks/bookmark_node_data.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698