Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1996943002: [esnext] Fix various callsites to use is_resumable, not is_generator (Closed)

Created:
4 years, 7 months ago by Dan Ehrenberg
Modified:
4 years, 6 months ago
Reviewers:
caitp (gmail), adamk, Yang
CC:
oth, rmcilroy, v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[esnext] Fix various callsites to use is_resumable, not is_generator Async functions are built out of generators, but the SharedFunctionInfo returns false for is_generator. is_resumable is the broader query. This patch fixes many parts of V8 to refer to is_resumable as appropriate. One incidental change is to remove a check for generators extending classes. This is part of a general check for constructors being the only thing which can extend classes, so it is removed here and the error message for the general case is made more accurate. BUG=v8:4483 Committed: https://crrev.com/46253e743df20c67bd524cf6f4288f549cb72739 Cr-Commit-Position: refs/heads/master@{#36621}

Patch Set 1 #

Total comments: 10

Patch Set 2 : formatting #

Patch Set 3 : Fix test expectations #

Patch Set 4 : fix test better #

Patch Set 5 : Add CHECK #

Patch Set 6 : fix dcheck #

Patch Set 7 : #

Patch Set 8 : Fix DCHECK #

Patch Set 9 : fix dcheck again #

Total comments: 2

Patch Set 10 : style fix #

Patch Set 11 : style fix #

Patch Set 12 : Add (failing!) breakpoint tests #

Patch Set 13 : Fix tests, add generator tests #

Patch Set 14 : fix formatting #

Patch Set 15 : formatting again #

Patch Set 16 : don't pass unneeded zero #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -93 lines) Patch
M src/compiler.cc View 1 2 3 4 5 2 chunks +10 lines, -8 lines 0 comments Download
M src/debug/debug.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +4 lines, -2 lines 0 comments Download
M src/debug/liveedit.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 2 3 4 5 6 3 chunks +9 lines, -5 lines 0 comments Download
M src/messages.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -4 lines 0 comments Download
M src/objects-printer.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 2 3 4 5 6 7 8 2 chunks +6 lines, -11 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 1 2 3 4 5 6 7 8 9 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/debug-generator-break.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +8 lines, -10 lines 0 comments Download
A + test/mjsunit/debug-generator-break-on-stack.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +7 lines, -9 lines 0 comments Download
M test/mjsunit/harmony/async-await-basic.js View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/debug-async-break.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +76 lines, -0 lines 0 comments Download
A + test/mjsunit/harmony/debug-async-break-on-stack.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +41 lines, -21 lines 0 comments Download
M test/webkit/class-syntax-extends.js View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M test/webkit/class-syntax-extends-expected.txt View 1 2 3 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 69 (33 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996943002/1
4 years, 7 months ago (2016-05-20 13:09:33 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15662)
4 years, 7 months ago (2016-05-20 13:12:47 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996943002/20001
4 years, 7 months ago (2016-05-20 13:14:25 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/1958) v8_linux64_avx2_rel_ng_triggered on ...
4 years, 7 months ago (2016-05-20 13:34:18 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996943002/40001
4 years, 7 months ago (2016-05-20 13:34:47 UTC) #11
caitp (gmail)
https://codereview.chromium.org/1996943002/diff/1/src/debug/debug.cc File src/debug/debug.cc (right): https://codereview.chromium.org/1996943002/diff/1/src/debug/debug.cc#newcode1334 src/debug/debug.cc:1334: bool include_generators = !is_interpreted && shared->is_resumable(); I imagine this ...
4 years, 7 months ago (2016-05-20 13:35:56 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/1987) v8_linux64_asan_rel_ng_triggered on ...
4 years, 7 months ago (2016-05-20 13:57:40 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996943002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996943002/60001
4 years, 7 months ago (2016-05-20 14:50:13 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996943002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996943002/80001
4 years, 7 months ago (2016-05-20 14:57:33 UTC) #19
Dan Ehrenberg
This patch doesn't add all the debugger tests, but it fixes basic issues that should've ...
4 years, 7 months ago (2016-05-20 14:59:19 UTC) #20
caitp (gmail)
On 2016/05/20 14:59:19, Dan Ehrenberg wrote: > This patch doesn't add all the debugger tests, ...
4 years, 7 months ago (2016-05-20 15:21:38 UTC) #21
caitp (gmail)
On 2016/05/20 15:21:38, caitp wrote: > On 2016/05/20 14:59:19, Dan Ehrenberg wrote: > > This ...
4 years, 7 months ago (2016-05-20 15:22:05 UTC) #22
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/1978) v8_linux64_avx2_rel_ng_triggered on ...
4 years, 7 months ago (2016-05-20 15:29:55 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996943002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996943002/100001
4 years, 6 months ago (2016-05-27 14:31:11 UTC) #26
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/2290) v8_linux64_avx2_rel_ng_triggered on ...
4 years, 6 months ago (2016-05-27 14:47:42 UTC) #28
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996943002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996943002/120001
4 years, 6 months ago (2016-05-27 15:50:32 UTC) #30
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/6418) v8_linux64_rel_ng_triggered on ...
4 years, 6 months ago (2016-05-27 16:09:52 UTC) #32
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996943002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996943002/140001
4 years, 6 months ago (2016-05-27 17:04:09 UTC) #34
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/6420) v8_linux64_rel_ng_triggered on ...
4 years, 6 months ago (2016-05-27 17:22:40 UTC) #36
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996943002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996943002/140001
4 years, 6 months ago (2016-05-27 17:36:09 UTC) #38
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/2303) v8_linux64_avx2_rel_ng_triggered on ...
4 years, 6 months ago (2016-05-27 17:41:01 UTC) #40
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996943002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996943002/160001
4 years, 6 months ago (2016-05-27 18:08:27 UTC) #42
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 18:36:43 UTC) #44
adamk
+yang This seems like the right way for the code to look, but I do ...
4 years, 6 months ago (2016-05-27 20:42:29 UTC) #47
Yang
LGTM. I assume we are going to have some tests that have async functions on ...
4 years, 6 months ago (2016-05-30 12:32:46 UTC) #48
Dan Ehrenberg
Working on tests. https://codereview.chromium.org/1996943002/diff/160001/src/debug/debug.cc File src/debug/debug.cc (right): https://codereview.chromium.org/1996943002/diff/160001/src/debug/debug.cc#newcode1332 src/debug/debug.cc:1332: bool include_generators = !is_interpreted && shared->is_resumable(); ...
4 years, 6 months ago (2016-05-31 08:53:37 UTC) #49
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996943002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996943002/240001
4 years, 6 months ago (2016-05-31 16:08:36 UTC) #51
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16234)
4 years, 6 months ago (2016-05-31 16:12:27 UTC) #53
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996943002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996943002/260001
4 years, 6 months ago (2016-05-31 16:20:16 UTC) #55
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16237)
4 years, 6 months ago (2016-05-31 16:25:07 UTC) #57
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996943002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996943002/280001
4 years, 6 months ago (2016-05-31 16:28:56 UTC) #59
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996943002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996943002/300001
4 years, 6 months ago (2016-05-31 16:51:10 UTC) #61
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996943002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996943002/300001
4 years, 6 months ago (2016-05-31 17:10:32 UTC) #65
Dan Ehrenberg
On 2016/05/31 at 16:51:10, commit-bot wrote: > Dry run: CQ is trying da patch. Follow ...
4 years, 6 months ago (2016-05-31 17:13:02 UTC) #66
commit-bot: I haz the power
Committed patchset #16 (id:300001)
4 years, 6 months ago (2016-05-31 17:14:07 UTC) #67
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 17:15:32 UTC) #69
Message was sent while issue was closed.
Patchset 16 (id:??) landed as
https://crrev.com/46253e743df20c67bd524cf6f4288f549cb72739
Cr-Commit-Position: refs/heads/master@{#36621}

Powered by Google App Engine
This is Rietveld 408576698