Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: src/debug/liveedit.cc

Issue 1996943002: [esnext] Fix various callsites to use is_resumable, not is_generator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: don't pass unneeded zero Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/debug.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/liveedit.h" 5 #include "src/debug/liveedit.h"
6 6
7 #include "src/ast/scopeinfo.h" 7 #include "src/ast/scopeinfo.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/compilation-cache.h" 10 #include "src/compilation-cache.h"
(...skipping 1662 matching lines...) Expand 10 before | Expand all | Expand 10 after
1673 for (; frame_index < frames.length(); frame_index++) { 1673 for (; frame_index < frames.length(); frame_index++) {
1674 StackFrame* frame = frames[frame_index]; 1674 StackFrame* frame = frames[frame_index];
1675 if (frame->is_exit()) { 1675 if (frame->is_exit()) {
1676 non_droppable_frame_found = true; 1676 non_droppable_frame_found = true;
1677 non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_NATIVE_CODE; 1677 non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_NATIVE_CODE;
1678 break; 1678 break;
1679 } 1679 }
1680 if (frame->is_java_script()) { 1680 if (frame->is_java_script()) {
1681 SharedFunctionInfo* shared = 1681 SharedFunctionInfo* shared =
1682 JavaScriptFrame::cast(frame)->function()->shared(); 1682 JavaScriptFrame::cast(frame)->function()->shared();
1683 if (shared->is_generator()) { 1683 if (shared->is_resumable()) {
1684 non_droppable_frame_found = true; 1684 non_droppable_frame_found = true;
1685 non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_GENERATOR; 1685 non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_GENERATOR;
1686 break; 1686 break;
1687 } 1687 }
1688 } 1688 }
1689 if (target.MatchActivation( 1689 if (target.MatchActivation(
1690 frame, LiveEdit::FUNCTION_BLOCKED_ON_ACTIVE_STACK)) { 1690 frame, LiveEdit::FUNCTION_BLOCKED_ON_ACTIVE_STACK)) {
1691 target_frame_found = true; 1691 target_frame_found = true;
1692 bottom_js_frame_index = frame_index; 1692 bottom_js_frame_index = frame_index;
1693 } 1693 }
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
2043 scope_info_length++; 2043 scope_info_length++;
2044 2044
2045 current_scope = current_scope->outer_scope(); 2045 current_scope = current_scope->outer_scope();
2046 } 2046 }
2047 2047
2048 return scope_info_list; 2048 return scope_info_list;
2049 } 2049 }
2050 2050
2051 } // namespace internal 2051 } // namespace internal
2052 } // namespace v8 2052 } // namespace v8
OLDNEW
« no previous file with comments | « src/debug/debug.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698