Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Side by Side Diff: src/debug/liveedit.cc

Issue 1996943002: [esnext] Fix various callsites to use is_resumable, not is_generator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/liveedit.h" 5 #include "src/debug/liveedit.h"
6 6
7 #include "src/ast/scopeinfo.h" 7 #include "src/ast/scopeinfo.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/compilation-cache.h" 10 #include "src/compilation-cache.h"
(...skipping 1654 matching lines...) Expand 10 before | Expand all | Expand 10 after
1665 for (; frame_index < frames.length(); frame_index++) { 1665 for (; frame_index < frames.length(); frame_index++) {
1666 StackFrame* frame = frames[frame_index]; 1666 StackFrame* frame = frames[frame_index];
1667 if (frame->is_exit()) { 1667 if (frame->is_exit()) {
1668 non_droppable_frame_found = true; 1668 non_droppable_frame_found = true;
1669 non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_NATIVE_CODE; 1669 non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_NATIVE_CODE;
1670 break; 1670 break;
1671 } 1671 }
1672 if (frame->is_java_script()) { 1672 if (frame->is_java_script()) {
1673 SharedFunctionInfo* shared = 1673 SharedFunctionInfo* shared =
1674 JavaScriptFrame::cast(frame)->function()->shared(); 1674 JavaScriptFrame::cast(frame)->function()->shared();
1675 if (shared->is_generator()) { 1675 if (shared->is_resumable()) {
caitp (gmail) 2016/05/20 13:35:56 Maybe a test similar to generators-debug-liveedit.
Dan Ehrenberg 2016/05/20 14:59:19 Yes
1676 non_droppable_frame_found = true; 1676 non_droppable_frame_found = true;
1677 non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_GENERATOR; 1677 non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_GENERATOR;
1678 break; 1678 break;
1679 } 1679 }
1680 } 1680 }
1681 if (target.MatchActivation( 1681 if (target.MatchActivation(
1682 frame, LiveEdit::FUNCTION_BLOCKED_ON_ACTIVE_STACK)) { 1682 frame, LiveEdit::FUNCTION_BLOCKED_ON_ACTIVE_STACK)) {
1683 target_frame_found = true; 1683 target_frame_found = true;
1684 bottom_js_frame_index = frame_index; 1684 bottom_js_frame_index = frame_index;
1685 } 1685 }
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
2035 scope_info_length++; 2035 scope_info_length++;
2036 2036
2037 current_scope = current_scope->outer_scope(); 2037 current_scope = current_scope->outer_scope();
2038 } 2038 }
2039 2039
2040 return scope_info_list; 2040 return scope_info_list;
2041 } 2041 }
2042 2042
2043 } // namespace internal 2043 } // namespace internal
2044 } // namespace v8 2044 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698