src/debug/liveedit.cc - Issue 1996943002: [esnext] Fix various callsites to use is_resumable, not is_generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/liveedit.cc

Issue 1996943002: [esnext] Fix various callsites to use is_resumable, not is_generator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: don't pass unneeded zero Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug/liveedit.cc

diff --git a/src/debug/liveedit.cc b/src/debug/liveedit.cc

index 5b04bbc415f3852a646b54eaa61576362af19f6c..fe08607d1007852a074bbdf4e8cbf8a0e7d7ff91 100644

--- a/src/debug/liveedit.cc

+++ b/src/debug/liveedit.cc

@@ -1680,7 +1680,7 @@ static const char* DropActivationsInActiveThreadImpl(Isolate* isolate,

if (frame->is_java_script()) {

SharedFunctionInfo* shared =

JavaScriptFrame::cast(frame)->function()->shared();

- if (shared->is_generator()) {

+ if (shared->is_resumable()) {

non_droppable_frame_found = true;

non_droppable_reason = LiveEdit::FUNCTION_BLOCKED_UNDER_GENERATOR;

break;

« no previous file with comments | « src/debug/debug.cc ('k') | src/factory.cc » ('j') | no next file with comments »