👻 Reland of Merge android's use_gold settings with the main use_gold GN arg logic

Reland of Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android setting -Wl,--icf=all in a different spot.

Reason for reland:
Removed --icf=safe for x86

BUG=606749, 576197, 611668
Committed: https://crrev.com/10371eae8d24d0ea7efa880571d51d62ce8f197c
Cr-Commit-Position: refs/heads/master@{#394655}

[agrieve, 2016-05-18 20:32:24]

Created Reland of 👻 Merge android's use_gold settings with the main use_gold GN
arg logic

[agrieve, 2016-05-18 20:33:19]

Description was changed from

==========
Reland of 👻 Merge android's use_gold settings with the main use_gold GN arg
logic (patchset #2 id:130001 of https://codereview.chromium.org/1979043002/ )

Reason for revert:
Will attempt to fix.

Original issue's description:
> Revert of 👻 Merge android's use_gold settings with the main use_gold GN arg
logic (patchset #2 id:20001 of https://codereview.chromium.org/1972183003/ )
> 
> Reason for revert:
> causing crash on x86 after the user signs in
> 
> https://bugs.chromium.org/p/chromium/issues/detail?id=611668
> 
> Original issue's description:
> > Merge android's use_gold settings with the main use_gold GN arg logic
> >
> > This also fixes Android settin -Wl,--icf=all in a different spot.
> >
> > BUG=606749
> >
> > Committed: https://crrev.com/0f484bfda36d849c474922639f94eaf12d785d04
> > Cr-Commit-Position: refs/heads/master@{#393355}
> 
> TBR=dpranke@chromium.org,agrieve@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=606749
> 
> Committed: https://crrev.com/e0f86c9c79b888051c81609f496fe7b598dc4e51
> Cr-Commit-Position: refs/heads/master@{#393738}

TBR=dpranke@chromium.org,jbudorick@chromium.org,mlliu@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=606749
==========

to

==========
Reland of Merge android's use_gold settings with the main use_gold GN arg logic

Reason for revert:
Will attempt to fix.

This also fixes Android setting -Wl,--icf=all in a different spot.

BUG=606749
==========

[Dirk Pranke, 2016-05-18 21:59:52]

On 2016/05/18 20:32:24, agrieve wrote:
> Created Reland of 👻 Merge android's use_gold settings with the main use_gold
GN
> arg logic

How is this different from the original CL?

[agrieve, 2016-05-19 00:46:16]

On 2016/05/18 21:59:52, Dirk Pranke wrote:
> On 2016/05/18 20:32:24, agrieve wrote:
> > Created Reland of 👻 Merge android's use_gold settings with the main use_gold
> GN
> > arg logic
> 
> How is this different from the original CL?

It's not yet. Just reverted it so that I could "git cl patch" it in. Will update
when I think it's fixed.

Related: Do you know if the cause or repro steps were ever determined? Otherwise
I'm planning on just visually inspecting flags (which shouldn't change due to
this CL)

[Menglin, 2016-05-19 00:49:38]

On 2016/05/19 00:46:16, agrieve wrote:
> On 2016/05/18 21:59:52, Dirk Pranke wrote:
> > On 2016/05/18 20:32:24, agrieve wrote:
> > > Created Reland of 👻 Merge android's use_gold settings with the main
use_gold
> > GN
> > > arg logic
> > 
> > How is this different from the original CL?
> 
> It's not yet. Just reverted it so that I could "git cl patch" it in. Will
update
> when I think it's fixed.
> 
> Related: Do you know if the cause or repro steps were ever determined?
Otherwise
> I'm planning on just visually inspecting flags (which shouldn't change due to
> this CL)

I think the repro steps were determined. If you can get a x86 device, you should
be able to repro following the steps here
https://bugs.chromium.org/p/chromium/issues/detail?id=611668#c10

[agrieve, 2016-05-19 01:25:41]

Description was changed from

==========
Reland of Merge android's use_gold settings with the main use_gold GN arg logic

Reason for revert:
Will attempt to fix.

This also fixes Android setting -Wl,--icf=all in a different spot.

BUG=606749
==========

to

==========
Reland of Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android setting -Wl,--icf=all in a different spot.

Reason for reland:
Removed --icf=safe for x86

BUG=606749
==========

[agrieve, 2016-05-19 01:27:15]

On 2016/05/19 00:49:38, Menglin wrote:
> On 2016/05/19 00:46:16, agrieve wrote:
> > On 2016/05/18 21:59:52, Dirk Pranke wrote:
> > > On 2016/05/18 20:32:24, agrieve wrote:
> > > > Created Reland of 👻 Merge android's use_gold settings with the main
> use_gold
> > > GN
> > > > arg logic
> > > 
> > > How is this different from the original CL?
> > 
> > It's not yet. Just reverted it so that I could "git cl patch" it in. Will
> update
> > when I think it's fixed.
> > 
> > Related: Do you know if the cause or repro steps were ever determined?
> Otherwise
> > I'm planning on just visually inspecting flags (which shouldn't change due
to
> > this CL)
> 
> I think the repro steps were determined. If you can get a x86 device, you
should
> be able to repro following the steps here
> https://bugs.chromium.org/p/chromium/issues/detail?id=611668#c10

Alright, I'm pretty confident in the fix despite not having a device. Comparing
flags with / without my change it looks like "--icf=safe" appeared in the broken
one, while no --icf flag appears in the non-broken one. I've updated it to not
add --icf=safe for android.

[agrieve, 2016-05-19 01:27:38]

Description was changed from

==========
Reland of Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android setting -Wl,--icf=all in a different spot.

Reason for reland:
Removed --icf=safe for x86

BUG=606749
==========

to

==========
Reland of Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android setting -Wl,--icf=all in a different spot.

Reason for reland:
Removed --icf=safe for x86

BUG=606749,576197
==========

[Dirk Pranke, 2016-05-19 01:29:52]

lgtm.

[agrieve, 2016-05-19 01:30:33]

Description was changed from

==========
Reland of Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android setting -Wl,--icf=all in a different spot.

Reason for reland:
Removed --icf=safe for x86

BUG=606749,576197
==========

to

==========
Reland of Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android setting -Wl,--icf=all in a different spot.

Reason for reland:
Removed --icf=safe for x86

BUG=606749,576197,611668
==========

[agrieve, 2016-05-19 01:30:53]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-05-19 01:32:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1996433002/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1996433002/110001

[commit-bot: I haz the power, 2016-05-19 03:35:02]

Description was changed from

==========
Reland of Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android setting -Wl,--icf=all in a different spot.

Reason for reland:
Removed --icf=safe for x86

BUG=606749,576197,611668
==========

to

==========
Reland of Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android setting -Wl,--icf=all in a different spot.

Reason for reland:
Removed --icf=safe for x86

BUG=606749,576197,611668
==========

[commit-bot: I haz the power, 2016-05-19 03:35:03]

Committed patchset #2 (id:110001)

[commit-bot: I haz the power, 2016-05-19 03:36:22]

Description was changed from

==========
Reland of Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android setting -Wl,--icf=all in a different spot.

Reason for reland:
Removed --icf=safe for x86

BUG=606749,576197,611668
==========

to

==========
Reland of Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android setting -Wl,--icf=all in a different spot.

Reason for reland:
Removed --icf=safe for x86

BUG=606749,576197,611668

Committed: https://crrev.com/10371eae8d24d0ea7efa880571d51d62ce8f197c
Cr-Commit-Position: refs/heads/master@{#394655}
==========

[commit-bot: I haz the power, 2016-05-19 03:36:23]

Patchset 2 (id:??) landed as
https://crrev.com/10371eae8d24d0ea7efa880571d51d62ce8f197c
Cr-Commit-Position: refs/heads/master@{#394655}