Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 1979043002: Revert of 👻 Merge android's use_gold settings with the main use_gold GN arg logic (Closed)

Created:
4 years, 7 months ago by Menglin
Modified:
4 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 👻 Merge android's use_gold settings with the main use_gold GN arg logic (patchset #2 id:20001 of https://codereview.chromium.org/1972183003/ ) Reason for revert: causing crash on x86 after the user signs in https://bugs.chromium.org/p/chromium/issues/detail?id=611668 Original issue's description: > Merge android's use_gold settings with the main use_gold GN arg logic > > This also fixes Android settin -Wl,--icf=all in a different spot. > > BUG=606749 > > Committed: https://crrev.com/0f484bfda36d849c474922639f94eaf12d785d04 > Cr-Commit-Position: refs/heads/master@{#393355} TBR=dpranke@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=606749 Committed: https://crrev.com/e0f86c9c79b888051c81609f496fe7b598dc4e51 Cr-Commit-Position: refs/heads/master@{#393738}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -64 lines) Patch
M build/config/android/BUILD.gn View 1 5 chunks +41 lines, -4 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 3 chunks +24 lines, -34 lines 0 comments Download
M build/config/compiler/compiler.gni View 1 2 chunks +0 lines, -9 lines 0 comments Download
M build/config/gcc/BUILD.gn View 1 4 chunks +10 lines, -17 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Menglin
Created Revert of 👻 Merge android's use_gold settings with the main use_gold GN arg logic
4 years, 7 months ago (2016-05-14 02:17:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979043002/1
4 years, 7 months ago (2016-05-14 02:17:59 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-14 02:18:01 UTC) #4
Menglin
john please help lgtm this . thanks!
4 years, 7 months ago (2016-05-14 02:19:15 UTC) #6
jbudorick
lgtm
4 years, 7 months ago (2016-05-14 02:20:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979043002/1
4 years, 7 months ago (2016-05-14 02:21:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/5578) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-14 02:22:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979043002/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979043002/130001
4 years, 7 months ago (2016-05-14 02:42:38 UTC) #14
Dirk Pranke
lgtm.
4 years, 7 months ago (2016-05-14 02:53:59 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:130001)
4 years, 7 months ago (2016-05-14 20:26:33 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e0f86c9c79b888051c81609f496fe7b598dc4e51 Cr-Commit-Position: refs/heads/master@{#393738}
4 years, 7 months ago (2016-05-14 20:27:32 UTC) #19
agrieve
4 years, 7 months ago (2016-05-18 20:32:23 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:130001) has been created in
https://codereview.chromium.org/1996433002/ by agrieve@chromium.org.

The reason for reverting is: Will attempt to fix..

Powered by Google App Engine
This is Rietveld 408576698