👻 Merge android's use_gold settings with the main use_gold GN arg logic

Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android settin -Wl,--icf=all in a different spot.

BUG=606749
Committed: https://crrev.com/0f484bfda36d849c474922639f94eaf12d785d04
Cr-Commit-Position: refs/heads/master@{#393355}

[agrieve, 2016-05-12 15:56:30]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 15:56:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972183003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972183003/1

[agrieve, 2016-05-12 15:56:58]

Description was changed from

==========
Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android settin -Wl,--icf=all in a different spot.

BUG=606749
==========

to

==========
Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android settin -Wl,--icf=all in a different spot.

BUG=606749
==========

[agrieve, 2016-05-12 15:56:58]

agrieve@chromium.org changed reviewers:
+ dpranke@chromium.org

[agrieve, 2016-05-12 15:57:03]

On 2016/05/12 15:56:47, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1972183003/1
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1972183003/1

[commit-bot: I haz the power, 2016-05-12 16:15:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 16:15:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dirk Pranke, 2016-05-12 17:56:34]

lgtm.

[agrieve, 2016-05-12 20:15:12]

On 2016/05/12 17:56:34, Dirk Pranke wrote:
> lgtm.

Had to move the declare_args() for use_gold out of toolchain.gni. Turns out
toolchain.gni is included by gcc_toolchain.gni, which caused it to be picked up
via toolchain_args().

[agrieve, 2016-05-12 20:16:06]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-05-12 20:16:06]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1972183003/#ps20001
(title: "move use_gold toolchain.gni -> compiler.gni")

[commit-bot: I haz the power, 2016-05-12 20:16:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972183003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972183003/20001

[commit-bot: I haz the power, 2016-05-12 21:12:53]

Description was changed from

==========
Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android settin -Wl,--icf=all in a different spot.

BUG=606749
==========

to

==========
Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android settin -Wl,--icf=all in a different spot.

BUG=606749
==========

[commit-bot: I haz the power, 2016-05-12 21:12:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-12 21:14:20]

Description was changed from

==========
Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android settin -Wl,--icf=all in a different spot.

BUG=606749
==========

to

==========
Merge android's use_gold settings with the main use_gold GN arg logic

This also fixes Android settin -Wl,--icf=all in a different spot.

BUG=606749

Committed: https://crrev.com/0f484bfda36d849c474922639f94eaf12d785d04
Cr-Commit-Position: refs/heads/master@{#393355}
==========

[commit-bot: I haz the power, 2016-05-12 21:14:21]

Patchset 2 (id:??) landed as
https://crrev.com/0f484bfda36d849c474922639f94eaf12d785d04
Cr-Commit-Position: refs/heads/master@{#393355}

[Dirk Pranke, 2016-05-12 21:23:52]

On 2016/05/12 20:15:12, agrieve wrote:
> On 2016/05/12 17:56:34, Dirk Pranke wrote:
> > lgtm.
> 
> Had to move the declare_args() for use_gold out of toolchain.gni. Turns out
> toolchain.gni is included by gcc_toolchain.gni, which caused it to be picked
up
> via toolchain_args().

what do you mean "caused it to be picked up via toolchain_args()" ?

[agrieve, 2016-05-13 00:54:29]

On 2016/05/12 21:23:52, Dirk Pranke wrote:
> On 2016/05/12 20:15:12, agrieve wrote:
> > On 2016/05/12 17:56:34, Dirk Pranke wrote:
> > > lgtm.
> > 
> > Had to move the declare_args() for use_gold out of toolchain.gni. Turns out
> > toolchain.gni is included by gcc_toolchain.gni, which caused it to be picked
> up
> > via toolchain_args().
> 
> what do you mean "caused it to be picked up via toolchain_args()" ?

"invoker" actually includes global variables that are in scope of the invoker. 
So having use_gold in toolchain.gni caused the value of the arg to be passed
along to secondary toolchains with the same value (from the use_gold =
invoker.use_gold line in gcc_toolchain.gni).

[Menglin, 2016-05-14 02:17:49]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1979043002/ by mlliu@chromium.org.

The reason for reverting is: causing crash on x86 after the user signs in

https://bugs.chromium.org/p/chromium/issues/detail?id=611668.