Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: build/config/compiler/compiler.gni

Issue 1996433002: 👻 Reland of Merge android's use_gold settings with the main use_gold GN arg logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: delete --icf=safe Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/config/gcc/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/sanitizers/sanitizers.gni") 8 import("//build/config/sanitizers/sanitizers.gni")
9 import("//build/toolchain/toolchain.gni")
9 10
10 declare_args() { 11 declare_args() {
11 # How many symbols to include in the build. This affects the performance of 12 # How many symbols to include in the build. This affects the performance of
12 # the build since the symbols are large and dealing with them is slow. 13 # the build since the symbols are large and dealing with them is slow.
13 # 2 means regular build with symbols. 14 # 2 means regular build with symbols.
14 # 1 means minimal symbols, usually enough for backtraces only. 15 # 1 means minimal symbols, usually enough for backtraces only.
15 # 0 means no symbols. 16 # 0 means no symbols.
16 # -1 means auto-set according to debug/release and platform. 17 # -1 means auto-set according to debug/release and platform.
17 symbol_level = -1 18 symbol_level = -1
18 19
19 # Compile in such a way as to enable profiling of the generated code. For 20 # Compile in such a way as to enable profiling of the generated code. For
20 # example, don't omit the frame pointer and leave in symbols. 21 # example, don't omit the frame pointer and leave in symbols.
21 enable_profiling = false 22 enable_profiling = false
22 23
23 # Specify the current PGO phase, only used for the Windows MSVS build. Here's 24 # Specify the current PGO phase, only used for the Windows MSVS build. Here's
24 # the different values that can be used: 25 # the different values that can be used:
25 # 0 : Means that PGO is turned off. 26 # 0 : Means that PGO is turned off.
26 # 1 : Used during the PGI (instrumentation) phase. 27 # 1 : Used during the PGI (instrumentation) phase.
27 # 2 : Used during the PGO (optimization) phase. 28 # 2 : Used during the PGO (optimization) phase.
28 # 29 #
29 # TODO(sebmarchand): Add support for the PGU (update) phase. 30 # TODO(sebmarchand): Add support for the PGU (update) phase.
30 chrome_pgo_phase = 0 31 chrome_pgo_phase = 0
31 32
32 # Whether or not the official builds should be build with full WPO. 33 # Whether or not the official builds should be build with full WPO.
33 full_wpo_on_official = false 34 full_wpo_on_official = false
34 } 35 }
35 36
37 declare_args() {
38 # Whether to use the gold linker from binutils instead of lld or bfd.
39 use_gold = !use_lld &&
40 ((is_linux && (current_cpu == "x64" || current_cpu == "x86" ||
41 current_cpu == "arm")) ||
42 (is_android && (current_cpu == "x86" || current_cpu == "x64" ||
43 current_cpu == "arm")))
44 }
45
36 # If it wasn't manually set, set to an appropriate default. 46 # If it wasn't manually set, set to an appropriate default.
37 assert(symbol_level >= -1 && symbol_level <= 2, "Invalid symbol_level") 47 assert(symbol_level >= -1 && symbol_level <= 2, "Invalid symbol_level")
38 if (symbol_level == -1) { 48 if (symbol_level == -1) {
39 if (is_android && use_order_profiling) { 49 if (is_android && use_order_profiling) {
40 # With instrumentation enabled, debug info puts libchrome.so over 4gb, which 50 # With instrumentation enabled, debug info puts libchrome.so over 4gb, which
41 # causes the linker to produce an invalid ELF. http://crbug.com/574476 51 # causes the linker to produce an invalid ELF. http://crbug.com/574476
42 symbol_level = 0 52 symbol_level = 0
43 } else if (is_win && is_clang && !using_sanitizer) { 53 } else if (is_win && is_clang && !using_sanitizer) {
44 # TODO(thakis): Remove this again once building with clang/win and 54 # TODO(thakis): Remove this again once building with clang/win and
45 # debug info doesn't make link.exe run for hours. 55 # debug info doesn't make link.exe run for hours.
46 symbol_level = 1 56 symbol_level = 1
47 } else if (!is_linux || is_debug || is_official_build || is_chromecast) { 57 } else if (!is_linux || is_debug || is_official_build || is_chromecast) {
48 # Linux is slowed by having symbols as part of the target binary, whereas 58 # Linux is slowed by having symbols as part of the target binary, whereas
49 # Mac and Windows have them separate, so in Release Linux, default them off, 59 # Mac and Windows have them separate, so in Release Linux, default them off,
50 # but keep them on for Official builds and Chromecast builds. 60 # but keep them on for Official builds and Chromecast builds.
51 symbol_level = 2 61 symbol_level = 2
52 } else if (using_sanitizer) { 62 } else if (using_sanitizer) {
53 # Sanitizers require symbols for filename suppressions to work. 63 # Sanitizers require symbols for filename suppressions to work.
54 symbol_level = 1 64 symbol_level = 1
55 } else { 65 } else {
56 symbol_level = 0 66 symbol_level = 0
57 } 67 }
58 } 68 }
59 69
60 # PGO requires full WPO. 70 # PGO requires full WPO.
61 if (chrome_pgo_phase > 0) { 71 if (chrome_pgo_phase > 0) {
62 full_wpo_on_official = true 72 full_wpo_on_official = true
63 } 73 }
OLDNEW
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/config/gcc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698