Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1995983002: Fix "unused variable" warnings. (Closed)

Created:
4 years, 7 months ago by Peter Kasting
Modified:
4 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, gavinp+memory_chromium.org, yzshen+watch_chromium.org, scheib+watch_chromium.org, ortuno+watch_chromium.org, ben+mojo_chromium.org, grt+watch_chromium.org, chromoting-reviews_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, kalyank, jbudorick+watch_chromium.org, asvitkine+watch_chromium.org, piman+watch_chromium.org, darin (slow to review), sdefresne+watch_chromium.org, oshima+watch_chromium.org, wfh+watch_chromium.org, Aaron Boodman, mikecase+watch_chromium.org, cc-bugs_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix "unused variable" warnings. These were exposed by changing DISALLOW_COPY_AND_ASSIGN to use "= delete", and must be fixed before that change can land. See https://codereview.chromium.org/1981053002/ for the full CL. BUG=447156 TEST=none CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/65f37925f106348f3b2e16c29b73347b990f127c Cr-Commit-Position: refs/heads/master@{#395452}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -110 lines) Patch
M ash/wm/boot_splash_screen_chromeos.cc View 2 chunks +6 lines, -1 line 0 comments Download
M base/android/trace_event_binding.cc View 2 chunks +1 line, -7 lines 0 comments Download
M base/memory/shared_memory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/memory/shared_memory_mac.cc View 1 chunk +1 line, -6 lines 0 comments Download
M base/win/registry.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M cc/scheduler/begin_frame_source.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/scheduler/begin_frame_source.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 4 chunks +14 lines, -4 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/binder/transaction_data_reader.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/binder/transaction_data_reader.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/timezone/timezone_resolver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/timezone/timezone_resolver.cc View 1 chunk +1 line, -2 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_win.h View 1 chunk +1 line, -3 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_win.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_media_endpoint_service_provider.h View 1 chunk +0 lines, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_media_endpoint_service_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/usb_device_handle_usbfs.h View 1 chunk +0 lines, -1 line 0 comments Download
M gin/wrappable_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 3 chunks +1 line, -4 lines 1 comment Download
M ios/chrome/browser/metrics/mobile_session_shutdown_metrics_provider_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_channel_win.h View 1 chunk +0 lines, -3 lines 0 comments Download
M mash/webtest/webtest.cc View 4 chunks +3 lines, -6 lines 0 comments Download
M mash/wm/non_client_frame_controller.cc View 3 chunks +3 lines, -11 lines 0 comments Download
M mojo/edk/test/mojo_test_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/test/mojo_test_base.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/signaling/xmpp_signal_strategy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/shell/shell.h View 1 chunk +0 lines, -5 lines 0 comments Download
M skia/ext/image_operations.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M tools/android/forwarder2/host_controller.h View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/android/forwarder2/host_controller.cc View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Peter Kasting
The "none of these areas were big enough to get their own CL" misc. pile ...
4 years, 7 months ago (2016-05-19 07:43:37 UTC) #4
Peter Kasting
ping
4 years, 7 months ago (2016-05-20 18:42:21 UTC) #5
sdefresne
I think brettw is OOO this week.
4 years, 7 months ago (2016-05-20 19:52:21 UTC) #7
Peter Kasting
OK, then; changing from Brett to Ben.
4 years, 7 months ago (2016-05-20 19:55:17 UTC) #9
Peter Kasting
Turns out Brett, Ben, and John are all OOO. There aren't many src/ OWNERS left! ...
4 years, 7 months ago (2016-05-20 22:33:12 UTC) #11
brettw
lgtm
4 years, 7 months ago (2016-05-23 20:44:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995983002/1
4 years, 7 months ago (2016-05-23 20:45:11 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 23:13:42 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 23:15:34 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65f37925f106348f3b2e16c29b73347b990f127c
Cr-Commit-Position: refs/heads/master@{#395452}

Powered by Google App Engine
This is Rietveld 408576698