Implement DISALLOW_COPY_AND_ASSIGN using = delete.

Implement DISALLOW_COPY_AND_ASSIGN using = delete.

BUG=447156
TEST=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=rdevlin.cronin

Committed: https://crrev.com/16afbf1fd62d6d4d4cf34c148333bd5b7aaf997f
Cr-Commit-Position: refs/heads/master@{#395814}

[Peter Kasting, 2016-05-16 21:56:03]

Description was changed from

==========
Implement DISALLOW_COPY_AND_ASSIGN using = delete.

BUG=447156
TEST=none
==========

to

==========
Implement DISALLOW_COPY_AND_ASSIGN using = delete.

BUG=447156
TEST=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Peter Kasting, 2016-05-24 01:16:15]

pkasting@chromium.org changed reviewers:
+ thakis@chromium.org

[Peter Kasting, 2016-05-24 02:06:26]

pkasting@chromium.org changed reviewers:
+ hcarmona@chromium.org, lazyboy@chromium.org

[Peter Kasting, 2016-05-24 02:06:27]

Adding reviewers:

hcarmona: chrome/browser/extensions/api/autofill_private/ - this is due to
https://codereview.chromium.org/1957043002
lazyboy: extensions/browser/ - this is due to
https://codereview.chromium.org/1880933002

[hcarmona, 2016-05-24 02:16:06]

LGTM chrome/browser/extensions/api/autofill_private/

[lazyboy, 2016-05-24 02:22:49]

extensions/browser/extension_service_worker_message_filter.cc LGTM

[Peter Kasting, 2016-05-25 01:19:09]

Ping thakis -- this CL tends to go stale quickly as people continually add new
unused variables.

[Nico, 2016-05-25 01:40:24]

lgtm

This is awesome :-)

[Peter Kasting, 2016-05-25 01:48:04]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2016-05-25 01:48:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1981053002/540001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1981053002/540001

[commit-bot: I haz the power, 2016-05-25 01:57:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 01:57:09]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Peter Kasting, 2016-05-25 01:59:11]

Description was changed from

==========
Implement DISALLOW_COPY_AND_ASSIGN using = delete.

BUG=447156
TEST=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Implement DISALLOW_COPY_AND_ASSIGN using = delete.

BUG=447156
TEST=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=rdevlin.cronin
==========

[Peter Kasting, 2016-05-25 01:59:11]

pkasting@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Peter Kasting, 2016-05-25 01:59:30]

TBR to rdevlin.cronin for extensions/ OWNER

[Peter Kasting, 2016-05-25 01:59:38]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2016-05-25 02:00:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1981053002/540001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1981053002/540001

[Devlin, 2016-05-25 03:34:00]

extensions lgtm

[commit-bot: I haz the power, 2016-05-25 06:27:26]

Description was changed from

==========
Implement DISALLOW_COPY_AND_ASSIGN using = delete.

BUG=447156
TEST=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=rdevlin.cronin
==========

to

==========
Implement DISALLOW_COPY_AND_ASSIGN using = delete.

BUG=447156
TEST=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=rdevlin.cronin
==========

[commit-bot: I haz the power, 2016-05-25 06:27:27]

Committed patchset #28 (id:540001)

[commit-bot: I haz the power, 2016-05-25 06:29:12]

Description was changed from

==========
Implement DISALLOW_COPY_AND_ASSIGN using = delete.

BUG=447156
TEST=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=rdevlin.cronin
==========

to

==========
Implement DISALLOW_COPY_AND_ASSIGN using = delete.

BUG=447156
TEST=none
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=rdevlin.cronin

Committed: https://crrev.com/16afbf1fd62d6d4d4cf34c148333bd5b7aaf997f
Cr-Commit-Position: refs/heads/master@{#395814}
==========

[commit-bot: I haz the power, 2016-05-25 06:29:14]

Patchset 28 (id:??) landed as
https://crrev.com/16afbf1fd62d6d4d4cf34c148333bd5b7aaf997f
Cr-Commit-Position: refs/heads/master@{#395814}

[hajimehoshi, 2016-05-25 07:44:17]

A revert of this CL (patchset #28 id:540001) has been created in
https://codereview.chromium.org/2009783002/ by hajimehoshi@chromium.org.

The reason for reverting is: This causes compile errors on some bots (e.g.
https://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20...).

[Ryan Hamilton, 2016-05-25 14:10:04]

rch@chromium.org changed reviewers:
+ rch@chromium.org

[Ryan Hamilton, 2016-05-25 14:10:06]

Thanks for doing this!

https://codereview.chromium.org/1981053002/diff/540001/base/macros.h
File base/macros.h (right):

https://codereview.chromium.org/1981053002/diff/540001/base/macros.h#newcode24
base/macros.h:24: // This should be used in the private: declarations for a
class
Presumably, this advice about private: is no longer correct?

https://codereview.chromium.org/1981053002/diff/540001/base/macros.h#newcode32
base/macros.h:32: // This should be used in the private: declarations for a
class
ditto

[Peter Kasting, 2016-05-25 18:55:17]

https://codereview.chromium.org/1981053002/diff/540001/base/macros.h
File base/macros.h (right):

https://codereview.chromium.org/1981053002/diff/540001/base/macros.h#newcode24
base/macros.h:24: // This should be used in the private: declarations for a
class
On 2016/05/25 14:10:06, Ryan Hamilton wrote:
> Presumably, this advice about private: is no longer correct?

No, this advice is still correct.  We have not made any changes to how the macro
should be used.