Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3258)

Unified Diff: base/android/trace_event_binding.cc

Issue 1995983002: Fix "unused variable" warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/trace_event_binding.cc
diff --git a/base/android/trace_event_binding.cc b/base/android/trace_event_binding.cc
index 534d8552fcdeca8dd5fbf8d5b1568048eb9ba75d..8551f99f961b6c3f72164b517770d404cf559bdb 100644
--- a/base/android/trace_event_binding.cc
+++ b/base/android/trace_event_binding.cc
@@ -28,10 +28,7 @@ const char kLooperDispatchMessage[] = "Looper.dispatchMessage";
class TraceEventDataConverter {
public:
TraceEventDataConverter(JNIEnv* env, jstring jname, jstring jarg)
- : env_(env),
- jname_(jname),
- jarg_(jarg),
- name_(ConvertJavaStringToUTF8(env, jname)),
+ : name_(ConvertJavaStringToUTF8(env, jname)),
has_arg_(jarg != nullptr),
arg_(jarg ? ConvertJavaStringToUTF8(env, jarg) : "") {}
~TraceEventDataConverter() {
@@ -43,9 +40,6 @@ class TraceEventDataConverter {
const char* arg() { return has_arg_ ? arg_.c_str() : nullptr; }
private:
- JNIEnv* env_;
- jstring jname_;
- jstring jarg_;
std::string name_;
bool has_arg_;
std::string arg_;

Powered by Google App Engine
This is Rietveld 408576698