Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Side by Side Diff: base/android/trace_event_binding.cc

Issue 1995983002: Fix "unused variable" warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/trace_event_binding.h" 5 #include "base/android/trace_event_binding.h"
6 6
7 #include <jni.h> 7 #include <jni.h>
8 8
9 #include <set> 9 #include <set>
10 10
(...skipping 10 matching lines...) Expand all
21 namespace { 21 namespace {
22 22
23 const char kJavaCategory[] = "Java"; 23 const char kJavaCategory[] = "Java";
24 const char kToplevelCategory[] = "toplevel"; 24 const char kToplevelCategory[] = "toplevel";
25 const char kLooperDispatchMessage[] = "Looper.dispatchMessage"; 25 const char kLooperDispatchMessage[] = "Looper.dispatchMessage";
26 26
27 // Boilerplate for safely converting Java data to TRACE_EVENT data. 27 // Boilerplate for safely converting Java data to TRACE_EVENT data.
28 class TraceEventDataConverter { 28 class TraceEventDataConverter {
29 public: 29 public:
30 TraceEventDataConverter(JNIEnv* env, jstring jname, jstring jarg) 30 TraceEventDataConverter(JNIEnv* env, jstring jname, jstring jarg)
31 : env_(env), 31 : name_(ConvertJavaStringToUTF8(env, jname)),
32 jname_(jname),
33 jarg_(jarg),
34 name_(ConvertJavaStringToUTF8(env, jname)),
35 has_arg_(jarg != nullptr), 32 has_arg_(jarg != nullptr),
36 arg_(jarg ? ConvertJavaStringToUTF8(env, jarg) : "") {} 33 arg_(jarg ? ConvertJavaStringToUTF8(env, jarg) : "") {}
37 ~TraceEventDataConverter() { 34 ~TraceEventDataConverter() {
38 } 35 }
39 36
40 // Return saves values to pass to TRACE_EVENT macros. 37 // Return saves values to pass to TRACE_EVENT macros.
41 const char* name() { return name_.c_str(); } 38 const char* name() { return name_.c_str(); }
42 const char* arg_name() { return has_arg_ ? "arg" : nullptr; } 39 const char* arg_name() { return has_arg_ ? "arg" : nullptr; }
43 const char* arg() { return has_arg_ ? arg_.c_str() : nullptr; } 40 const char* arg() { return has_arg_ ? arg_.c_str() : nullptr; }
44 41
45 private: 42 private:
46 JNIEnv* env_;
47 jstring jname_;
48 jstring jarg_;
49 std::string name_; 43 std::string name_;
50 bool has_arg_; 44 bool has_arg_;
51 std::string arg_; 45 std::string arg_;
52 46
53 DISALLOW_COPY_AND_ASSIGN(TraceEventDataConverter); 47 DISALLOW_COPY_AND_ASSIGN(TraceEventDataConverter);
54 }; 48 };
55 49
56 class TraceEnabledObserver 50 class TraceEnabledObserver
57 : public trace_event::TraceLog::EnabledStateObserver { 51 : public trace_event::TraceLog::EnabledStateObserver {
58 public: 52 public:
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 TraceEventDataConverter converter(env, jname, nullptr); 144 TraceEventDataConverter converter(env, jname, nullptr);
151 TRACE_EVENT_COPY_ASYNC_END0(kJavaCategory, converter.name(), jid); 145 TRACE_EVENT_COPY_ASYNC_END0(kJavaCategory, converter.name(), jid);
152 } 146 }
153 147
154 bool RegisterTraceEvent(JNIEnv* env) { 148 bool RegisterTraceEvent(JNIEnv* env) {
155 return RegisterNativesImpl(env); 149 return RegisterNativesImpl(env);
156 } 150 }
157 151
158 } // namespace android 152 } // namespace android
159 } // namespace base 153 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698