third_party/WebKit/Source/modules/payments/PaymentDetailsTestHelper.cpp - Issue 1994913002: PaymentRequest: Remove id attribute from PaymentItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentDetailsTestHelper.cpp

Issue 1994913002: PaymentRequest: Remove id attribute from PaymentItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java ('k') | third_party/WebKit/Source/modules/payments/PaymentItem.idl » ('j') | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentDetailsTestHelper.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentDetailsTestHelper.cpp b/third_party/WebKit/Source/modules/payments/PaymentDetailsTestHelper.cpp

index b2906e54d49b36ae72a9bde4966f9d6ac9be9b36..ffaa6e542bc83e5c15cb2f967b83945e4792bd7a 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentDetailsTestHelper.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentDetailsTestHelper.cpp

@@ -31,12 +31,6 @@ void setValues(PaymentItemOrShippingOption& original, PaymentTestDataToChange da

if (data != PaymentTestDataAmount || modificationType != PaymentTestRemoveKey)

original.setAmount(itemAmount);

- if (data == PaymentTestDataId) {

please use gerrit instead 2016/05/19 17:48:20 Move this clause into buildShippingOptionForTest()

zino 2016/05/19 19:11:40 Done.

- if (modificationType == PaymentTestOverwriteValue)

- original.setId(valueToUse);

- } else {

- original.setId("id");

- }

if (data == PaymentTestDataLabel) {

if (modificationType == PaymentTestOverwriteValue)

original.setLabel(valueToUse);