Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Issue 1994913002: PaymentRequest: Remove id attribute from PaymentItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
index a406722453f5f1952f3440084a4c87702f846527..3aa7273396b7c07fe7f52bc39f04a8d8e7a950a3 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
@@ -56,7 +56,6 @@ struct TypeConverter<PaymentItemPtr, blink::PaymentItem> {
static PaymentItemPtr Convert(const blink::PaymentItem& input)
{
PaymentItemPtr output = PaymentItem::New();
- output->id = input.id();
output->label = input.label();
output->amount = CurrencyAmount::From(input.amount());
return output;
@@ -110,11 +109,6 @@ void validateShippingOptionsOrPaymentItems(HeapVector<T> items, ExceptionState&
{
String errorMessage;
for (const auto& item : items) {
- if (!item.hasId() || item.id().isEmpty()) {
please use gerrit instead 2016/05/19 17:48:20 Move this clause into validateShippingOptionIds().
zino 2016/05/19 19:11:40 Done.
- exceptionState.throwTypeError("Item id required");
- return;
- }
-
if (!item.hasLabel() || item.label().isEmpty()) {
exceptionState.throwTypeError("Item label required");
return;

Powered by Google App Engine
This is Rietveld 408576698