chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java - Issue 1994913002: PaymentRequest: Remove id attribute from PaymentItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 1994913002: PaymentRequest: Remove id attribute from PaymentItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentDetailsTestHelper.cpp » ('j') | third_party/WebKit/Source/modules/payments/PaymentDetailsTestHelper.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

index 831864ae1686fed829f04944bf488aa10e21eecc..1c65da678fb9be0f25186e183ab673654fd90a03 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

@@ -281,8 +281,8 @@ public class PaymentRequestImpl implements PaymentRequest, PaymentRequestUI.Clie

for (int i = 0; i < details.items.length; i++) {

PaymentItem item = details.items[i];

// "id", "label", "currencyCode", and "value" should be non-empty.

- if (item == null || TextUtils.isEmpty(item.id) || TextUtils.isEmpty(item.label)

- || item.amount == null || TextUtils.isEmpty(item.amount.currencyCode)

+ if (item == null || TextUtils.isEmpty(item.label) || item.amount == null

+ || TextUtils.isEmpty(item.amount.currencyCode)

|| TextUtils.isEmpty(item.amount.value)) {

return null;

}