PaymentRequest: Remove id attribute from PaymentItem.

third_party/WebKit/Source/modules/payments/PaymentDetailsTestHelper.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentDetailsTestHelper.h"
 
 #include "modules/payments/CurrencyAmount.h"
 #include "platform/heap/HeapAllocator.h"
 
 namespace blink {
 namespace {
 
 // PaymentItem and ShippingOption have identical structure.

[please use gerrit instead, 2016/05/19 17:48:20]

... except for the "id" field, which is present only in ShippingOption.

[zino, 2016/05/19 19:11:40]

Done.

 template <typename PaymentItemOrShippingOption>
 void setValues(PaymentItemOrShippingOption& original, PaymentTestDataToChange data, PaymentTestModificationType modificationType, const String& valueToUse)
 {
     CurrencyAmount itemAmount;
     if (data == PaymentTestDataCurrencyCode) {
         if (modificationType == PaymentTestOverwriteValue)
             itemAmount.setCurrencyCode(valueToUse);
     } else {
         itemAmount.setCurrencyCode("USD");
     }
     if (data == PaymentTestDataValue) {
         if (modificationType == PaymentTestOverwriteValue)
             itemAmount.setValue(valueToUse);
     } else {
         itemAmount.setValue("9.99");
     }
 
     if (data != PaymentTestDataAmount || modificationType != PaymentTestRemoveKey)
         original.setAmount(itemAmount);
 
-    if (data == PaymentTestDataId) {

[please use gerrit instead, 2016/05/19 17:48:20]

Move this clause into buildShippingOptionForTest(), because ShippingOption still
uses this field.

[zino, 2016/05/19 19:11:40]

Done.

-        if (modificationType == PaymentTestOverwriteValue)
-            original.setId(valueToUse);
-    } else {
-        original.setId("id");
-    }
     if (data == PaymentTestDataLabel) {
         if (modificationType == PaymentTestOverwriteValue)
             original.setLabel(valueToUse);
     } else {
         original.setLabel("Label");
     }
 }
 
 } // namespace
 
 PaymentItem buildPaymentItemForTest(PaymentTestDataToChange data, PaymentTestModificationType modificationType, const String& valueToUse)

[please use gerrit instead, 2016/05/19 17:49:50]

DCHECK_NE(data, PaymentTestDataId);

[zino, 2016/05/19 19:11:40]

Done.

 {
     PaymentItem item;
     setValues(item, data, modificationType, valueToUse);
     return item;
 }
 
 ShippingOption buildShippingOptionForTest(PaymentTestDataToChange data, PaymentTestModificationType modificationType, const String& valueToUse)
 {
     ShippingOption shippingOption;
     setValues(shippingOption, data, modificationType, valueToUse);
@@ skipping 15 matching lines @@
         shippingOption = buildShippingOptionForTest();
 
     PaymentDetails result;
     result.setItems(HeapVector<PaymentItem>(1, item));
     result.setShippingOptions(HeapVector<ShippingOption>(2, shippingOption));
 
     return result;
 }
 
 } // namespace blink