Fix overlay computation in GpuMemoryBufferVideoFramePool

Fix overlay computation in GpuMemoryBufferVideoFramePool

In https://codereview.chromium.org/1960563002, we changed the
computation of the ALLOW_OVERLAY flag, which disabled overlays. This
changes the logic back to its previous behavior.

While we're in the neighborhood, use regular TextureDrawQuads to draw
video frames. We originally used IOSurfaceDrawQuad because only it had
support for rectangle textures. TextureDrawQuad has had support for
rectangle textures for a while now.

BUG=611551
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/9c1004fad352061d1e2e4b410174b9eee2bccf0b
Cr-Commit-Position: refs/heads/master@{#394338}

[ccameron, 2016-05-17 23:15:05]

Description was changed from

==========
Fix overlay computation in GpuMemoryBufferVideoFramePool

In https://codereview.chromium.org/1960563002, we changed the
computation of the ALLOW_OVERLAY flag, which disabled overlays. This
changes the logic back to its previous behavior.

While we're in the neighborhood, use regular TextureDrawQuads to draw
video frames. We originally used IOSurfaceDrawQuad because only it had
support for rectangle textures. TextureDrawQuad has had support for
rectangle textures for a while now.

BUG=611551
==========

to

==========
Fix overlay computation in GpuMemoryBufferVideoFramePool

In https://codereview.chromium.org/1960563002, we changed the
computation of the ALLOW_OVERLAY flag, which disabled overlays. This
changes the logic back to its previous behavior.

While we're in the neighborhood, use regular TextureDrawQuads to draw
video frames. We originally used IOSurfaceDrawQuad because only it had
support for rectangle textures. TextureDrawQuad has had support for
rectangle textures for a while now.

BUG=611551
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ccameron, 2016-05-17 23:17:31]

ccameron@chromium.org changed reviewers:
+ hubbe@chromium.org

[ccameron, 2016-05-17 23:17:31]

ptal -- this returns behavior to how it was before
https://codereview.chromium.org/1993463002/.

[hubbe, 2016-05-18 00:03:32]

LGTM % one nit

https://codereview.chromium.org/1993463002/diff/1/media/video/gpu_memory_buff...
File media/video/gpu_memory_buffer_video_frame_pool.cc (right):

https://codereview.chromium.org/1993463002/diff/1/media/video/gpu_memory_buff...
media/video/gpu_memory_buffer_video_frame_pool.cc:610: // Compute whether or not
this frame may be displayed as an overlay.
Not a very good comment, as it doesn't explain why we sometimes ask the frame if
overlay is allowed and sometimes not.

[ccameron, 2016-05-18 03:04:00]

Thanks!

https://codereview.chromium.org/1993463002/diff/1/media/video/gpu_memory_buff...
File media/video/gpu_memory_buffer_video_frame_pool.cc (right):

https://codereview.chromium.org/1993463002/diff/1/media/video/gpu_memory_buff...
media/video/gpu_memory_buffer_video_frame_pool.cc:610: // Compute whether or not
this frame may be displayed as an overlay.
On 2016/05/18 00:03:32, hubbe wrote:
> Not a very good comment, as it doesn't explain why we sometimes ask the frame
if
> overlay is allowed and sometimes not.

Good point -- removed the comment, since it doesn't add anything.

[ccameron, 2016-05-18 03:04:07]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-05-18 03:04:07]

The patchset sent to the CQ was uploaded after l-g-t-m from hubbe@chromium.org
Link to the patchset: https://codereview.chromium.org/1993463002/#ps20001
(title: "Remove comment")

[commit-bot: I haz the power, 2016-05-18 03:04:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1993463002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1993463002/20001

[commit-bot: I haz the power, 2016-05-18 05:52:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-18 05:53:37]

Description was changed from

==========
Fix overlay computation in GpuMemoryBufferVideoFramePool

In https://codereview.chromium.org/1960563002, we changed the
computation of the ALLOW_OVERLAY flag, which disabled overlays. This
changes the logic back to its previous behavior.

While we're in the neighborhood, use regular TextureDrawQuads to draw
video frames. We originally used IOSurfaceDrawQuad because only it had
support for rectangle textures. TextureDrawQuad has had support for
rectangle textures for a while now.

BUG=611551
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Fix overlay computation in GpuMemoryBufferVideoFramePool

In https://codereview.chromium.org/1960563002, we changed the
computation of the ALLOW_OVERLAY flag, which disabled overlays. This
changes the logic back to its previous behavior.

While we're in the neighborhood, use regular TextureDrawQuads to draw
video frames. We originally used IOSurfaceDrawQuad because only it had
support for rectangle textures. TextureDrawQuad has had support for
rectangle textures for a while now.

BUG=611551
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/9c1004fad352061d1e2e4b410174b9eee2bccf0b
Cr-Commit-Position: refs/heads/master@{#394338}
==========

[commit-bot: I haz the power, 2016-05-18 05:53:39]

Patchset 2 (id:??) landed as
https://crrev.com/9c1004fad352061d1e2e4b410174b9eee2bccf0b
Cr-Commit-Position: refs/heads/master@{#394338}