Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1990773002: cc: Remove IOSurfaceDrawQuad (Closed)

Created:
4 years, 7 months ago by ccameron
Modified:
4 years, 7 months ago
Reviewers:
danakj, Fady Samuel, dcheng
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, cc-bugs_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, posciak+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove IOSurfaceDrawQuad This isn't being used anymore. It existed to support rectangle textures, but regular texture draw quads support that now. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/648c911f675f1b289718d01453ad04ef98e19fcf Cr-Commit-Position: refs/heads/master@{#394602}

Patch Set 1 #

Patch Set 2 : Set upstream correctly #

Patch Set 3 : Fix messages unittest #

Total comments: 1

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -370 lines) Patch
M cc/BUILD.gn View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M cc/cc.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/ipc/cc_param_traits.cc View 1 2 3 4 chunks +0 lines, -10 lines 0 comments Download
M cc/ipc/cc_param_traits_macros.h View 3 chunks +0 lines, -9 lines 0 comments Download
M cc/ipc/cc_param_traits_unittest.cc View 1 2 3 7 chunks +2 lines, -24 lines 0 comments Download
M cc/layers/video_layer_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/ca_layer_overlay.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M cc/output/delegating_renderer_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/output/gl_renderer.h View 4 chunks +0 lines, -7 lines 0 comments Download
M cc/output/gl_renderer.cc View 4 chunks +0 lines, -67 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/output/overlay_candidate.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/output/overlay_candidate.cc View 3 chunks +0 lines, -21 lines 0 comments Download
M cc/output/software_renderer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/quads/draw_quad.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/quads/draw_quad.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/quads/draw_quad_unittest.cc View 5 chunks +0 lines, -46 lines 0 comments Download
D cc/quads/io_surface_draw_quad.h View 1 chunk +0 lines, -62 lines 0 comments Download
D cc/quads/io_surface_draw_quad.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M cc/quads/largest_draw_quad.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/quads/render_pass.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/test/render_pass_test_utils.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/public/interfaces/quads.mojom View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
ccameron
ptal: this is just leaning on the delete key. danakj: cc/ and messages dcheng: .mojom ...
4 years, 7 months ago (2016-05-18 04:02:39 UTC) #5
Fady Samuel
Mus lgtm
4 years, 7 months ago (2016-05-18 04:04:34 UTC) #6
dcheng
rs lgtm
4 years, 7 months ago (2016-05-18 04:40:56 UTC) #7
danakj
LGTM https://codereview.chromium.org/1990773002/diff/40001/content/common/cc_messages_unittest.cc File content/common/cc_messages_unittest.cc (left): https://codereview.chromium.org/1990773002/diff/40001/content/common/cc_messages_unittest.cc#oldcode30 content/common/cc_messages_unittest.cc:30: using cc::IOSurfaceDrawQuad; This file moved to cc/ipc/ fyi
4 years, 7 months ago (2016-05-18 22:00:53 UTC) #8
ccameron
Thanks!
4 years, 7 months ago (2016-05-18 22:11:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990773002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990773002/60001
4 years, 7 months ago (2016-05-18 22:12:08 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-18 23:44:19 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 23:46:59 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/648c911f675f1b289718d01453ad04ef98e19fcf
Cr-Commit-Position: refs/heads/master@{#394602}

Powered by Google App Engine
This is Rietveld 408576698