Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1960563002: Add media::VideoFrame::WrapNativeTextures() (Closed)

Created:
4 years, 7 months ago by jbauman
Modified:
4 years, 7 months ago
Reviewers:
piman, hubbe, miu, alokp
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add media::VideoFrame::WrapNativeTextures() This is more flexible, as it lets us specify NV12 frames with 2 mailboxes, in addition to 1-mailbox and 3-mailbox frames. It replaces every usage of WrapNativeTexture() and WrapYUV420NativeTextures(). BUG=574292 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/b97bf4cfe9d8666c0f48f5b0487c722648e6cd1c Cr-Commit-Position: refs/heads/master@{#393116}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -139 lines) Patch
M cc/layers/video_layer_impl_unittest.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M cc/resources/video_resource_updater_unittest.cc View 2 chunks +23 lines, -25 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chromecast/renderer/media/hole_frame_factory.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M media/base/video_frame.h View 1 chunk +4 lines, -18 lines 0 comments Download
M media/base/video_frame.cc View 2 chunks +4 lines, -32 lines 0 comments Download
M media/base/video_frame_unittest.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M media/blink/webmediaplayer_cast_android.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M media/renderers/skcanvas_video_renderer_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool.cc View 1 chunk +7 lines, -25 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
jbauman
miu@: please review hubbe@: media/ OWNERS review piman@: cc/ OWNERS review
4 years, 7 months ago (2016-05-07 00:28:25 UTC) #4
piman
lgtm
4 years, 7 months ago (2016-05-09 16:27:16 UTC) #5
miu
lgtm. Much nicer! :-)
4 years, 7 months ago (2016-05-10 00:40:07 UTC) #6
jbauman
hubbe@: ping
4 years, 7 months ago (2016-05-11 22:09:43 UTC) #7
hubbe
lgtm
4 years, 7 months ago (2016-05-11 22:20:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960563002/40001
4 years, 7 months ago (2016-05-11 22:48:59 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/181652)
4 years, 7 months ago (2016-05-11 22:57:16 UTC) #12
jbauman
alokp: chromecast/ OWNERS review.
4 years, 7 months ago (2016-05-11 22:59:14 UTC) #14
alokp
lgtm
4 years, 7 months ago (2016-05-11 23:02:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960563002/40001
4 years, 7 months ago (2016-05-11 23:29:58 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-12 00:20:36 UTC) #19
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/b97bf4cfe9d8666c0f48f5b0487c722648e6cd1c Cr-Commit-Position: refs/heads/master@{#393116}
4 years, 7 months ago (2016-05-12 00:23:47 UTC) #21
ccameron
4 years, 7 months ago (2016-05-16 17:19:28 UTC) #22
Message was sent while issue was closed.
On 2016/05/12 00:23:47, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/b97bf4cfe9d8666c0f48f5b0487c722648e6cd1c
> Cr-Commit-Position: refs/heads/master@{#393116}

This has changed the way that YUV textures are drawn on Mac (and possibly other
platforms). Trying to figure out a fix, if I can't soon, I'll have to revert.

Powered by Google App Engine
This is Rietveld 408576698