chrome/browser/media/router/mojo/media_router.mojom - Issue 1993373002: [Media Router] Consistently refer to issue's learn more help page by ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/mojo/media_router.mojom

Issue 1993373002: [Media Router] Consistently refer to issue's learn more help page by ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per imcheng@'s comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/issue_unittest.cc ('k') | chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/mojo/media_router.mojom

diff --git a/chrome/browser/media/router/mojo/media_router.mojom b/chrome/browser/media/router/mojo/media_router.mojom

index a4c73c19ff44d1c1b902fa5afd9bfe9d6bd35713..816527e1d1d0c9cd3d1fc8f3cc37cb230a49a85a 100644

--- a/chrome/browser/media/router/mojo/media_router.mojom

+++ b/chrome/browser/media/router/mojo/media_router.mojom

@@ -97,8 +97,8 @@ struct Issue {

array<ActionType>? secondary_actions;

- // A help page to be opened if users select learn_more.

- string? help_url;

+ // The ID of the help page to be opened if users select learn_more.

+ int32 help_page_id;

};

struct RouteMessage {