Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Side by Side Diff: chrome/browser/media/router/issue.cc

Issue 1993373002: [Media Router] Consistently refer to issue's learn more help page by ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per imcheng@'s comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/guid.h" 5 #include "base/guid.h"
6 #include "chrome/browser/media/router/issue.h" 6 #include "chrome/browser/media/router/issue.h"
7 7
8 namespace media_router { 8 namespace media_router {
9 9
10 IssueAction::IssueAction(const IssueAction::Type type) : type_(type) { 10 IssueAction::IssueAction(const IssueAction::Type type) : type_(type) {
11 } 11 }
12 12
13 IssueAction::~IssueAction() { 13 IssueAction::~IssueAction() {
14 } 14 }
15 15
16 Issue::Issue(const std::string& title, 16 Issue::Issue(const std::string& title,
17 const std::string& message, 17 const std::string& message,
18 const IssueAction& default_action, 18 const IssueAction& default_action,
19 const std::vector<IssueAction>& secondary_actions, 19 const std::vector<IssueAction>& secondary_actions,
20 const MediaRoute::Id& route_id, 20 const MediaRoute::Id& route_id,
21 const Issue::Severity severity, 21 const Issue::Severity severity,
22 bool is_blocking, 22 bool is_blocking,
23 const std::string& help_url) 23 int help_page_id)
24 : title_(title), 24 : title_(title),
25 message_(message), 25 message_(message),
26 default_action_(default_action), 26 default_action_(default_action),
27 secondary_actions_(secondary_actions), 27 secondary_actions_(secondary_actions),
28 route_id_(route_id), 28 route_id_(route_id),
29 severity_(severity), 29 severity_(severity),
30 id_(base::GenerateGUID()), 30 id_(base::GenerateGUID()),
31 is_blocking_(is_blocking), 31 is_blocking_(is_blocking),
32 help_url_(GURL(help_url)) { 32 help_page_id_(help_page_id) {
33 DCHECK(!title_.empty()); 33 DCHECK(!title_.empty());
34 DCHECK(severity_ != FATAL || is_blocking_) << "Severity is " << severity_; 34 DCHECK(severity_ != FATAL || is_blocking_) << "Severity is " << severity_;
35 35
36 // Check that the default and secondary actions are not of the same type. 36 // Check that the default and secondary actions are not of the same type.
37 if (!secondary_actions_.empty()) 37 if (!secondary_actions_.empty())
38 DCHECK_NE(default_action_.type(), secondary_actions_[0].type()); 38 DCHECK_NE(default_action_.type(), secondary_actions_[0].type());
39 } 39 }
40 40
41 Issue::Issue(const Issue& other) = default; 41 Issue::Issue(const Issue& other) = default;
42 42
43 Issue::~Issue() { 43 Issue::~Issue() {
44 } 44 }
45 45
46 bool Issue::Equals(const Issue& other) const { 46 bool Issue::Equals(const Issue& other) const {
47 return id_ == other.id_; 47 return id_ == other.id_;
48 } 48 }
49 49
50 } // namespace media_router 50 } // namespace media_router
OLDNEW
« no previous file with comments | « chrome/browser/media/router/issue.h ('k') | chrome/browser/media/router/issue_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698