Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3965)

Unified Diff: chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc

Issue 1993373002: [Media Router] Consistently refer to issue's learn more help page by ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per imcheng@'s comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc
diff --git a/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc b/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc
index 961c870b94b9e4de87eb33b395322f59ad5be69d..31994662cd6008726809083a04bd0ea83729df87 100644
--- a/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc
+++ b/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc
@@ -131,13 +131,13 @@ TEST(MediaRouterTypeConvertersTest, ConvertIssue) {
mojoIssue->secondary_actions[0] = interfaces::Issue::ActionType::DISMISS;
mojoIssue->severity = interfaces::Issue::Severity::WARNING;
mojoIssue->is_blocking = true;
- mojoIssue->help_url = "help_url";
+ mojoIssue->help_page_id = 12345;
std::vector<IssueAction> secondary_actions;
secondary_actions.push_back(IssueAction(IssueAction::TYPE_DISMISS));
Issue expected_issue(
"title", "msg", IssueAction(IssueAction::TYPE_LEARN_MORE),
- secondary_actions, "routeId", Issue::WARNING, true, "help_url");
+ secondary_actions, "routeId", Issue::WARNING, true, 12345);
Issue converted_issue = mojo::TypeConverter<
media_router::Issue,
media_router::interfaces::IssuePtr>::Convert(mojoIssue);
@@ -155,7 +155,7 @@ TEST(MediaRouterTypeConvertersTest, ConvertIssue) {
EXPECT_EQ(expected_issue.route_id(), converted_issue.route_id());
EXPECT_EQ(expected_issue.severity(), converted_issue.severity());
EXPECT_EQ(expected_issue.is_blocking(), converted_issue.is_blocking());
- EXPECT_EQ(expected_issue.help_url(), converted_issue.help_url());
+ EXPECT_EQ(expected_issue.help_page_id(), converted_issue.help_page_id());
// Ensure that the internal Issue objects are considered distinct
// (they possess different IDs.)
@@ -172,7 +172,7 @@ TEST(MediaRouterTypeConvertersTest, ConvertIssueWithoutOptionalFields) {
Issue expected_issue("title", "", IssueAction(IssueAction::TYPE_DISMISS),
std::vector<IssueAction>(), "", Issue::WARNING, true,
- "");
+ -1);
Issue converted_issue = mojo::TypeConverter<
media_router::Issue,
« no previous file with comments | « chrome/browser/media/router/mojo/media_router_type_converters.cc ('k') | chrome/browser/media/router/test_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698