Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1993173002: Fix "unused variable" warnings. (Closed)

Created:
4 years, 7 months ago by Peter Kasting
Modified:
4 years, 7 months ago
Reviewers:
hubbe
CC:
chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, imcheng+watch_chromium.org, Aaron Boodman, posciak+watch_chromium.org, jasonroberts+watch_google.com, viettrungluu+watch_chromium.org, avayvod+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, piman+watch_chromium.org, xjz+watch_chromium.org, ben+mojo_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix "unused variable" warnings. These were exposed by changing DISALLOW_COPY_AND_ASSIGN to use "= delete", and must be fixed before that change can land. See https://codereview.chromium.org/1981053002/ for the full CL. BUG=447156 TEST=none Committed: https://crrev.com/93c899178a3c2c46ce9cac2c9da2134d81cb4f94 Cr-Commit-Position: refs/heads/master@{#394816}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -38 lines) Patch
M media/base/mac/avfoundation_glue.mm View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/sender/audio_encoder.cc View 3 chunks +1 line, -29 lines 3 comments Download
M media/gpu/avda_codec_image.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/gpu/avda_codec_image.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/service_factory_impl.h View 1 chunk +6 lines, -1 line 0 comments Download
M media/mojo/services/service_factory_impl.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Peter Kasting
https://codereview.chromium.org/1993173002/diff/1/media/cast/sender/audio_encoder.cc File media/cast/sender/audio_encoder.cc (left): https://codereview.chromium.org/1993173002/diff/1/media/cast/sender/audio_encoder.cc#oldcode471 media/cast/sender/audio_encoder.cc:471: const_cast<bool&>(can_resume_) = can_resume != 0; This member is never ...
4 years, 7 months ago (2016-05-19 07:23:29 UTC) #2
hubbe
lgtm https://codereview.chromium.org/1993173002/diff/1/media/cast/sender/audio_encoder.cc File media/cast/sender/audio_encoder.cc (left): https://codereview.chromium.org/1993173002/diff/1/media/cast/sender/audio_encoder.cc#oldcode471 media/cast/sender/audio_encoder.cc:471: const_cast<bool&>(can_resume_) = can_resume != 0; On 2016/05/19 07:23:29, ...
4 years, 7 months ago (2016-05-19 17:21:41 UTC) #3
Peter Kasting
https://codereview.chromium.org/1993173002/diff/1/media/cast/sender/audio_encoder.cc File media/cast/sender/audio_encoder.cc (left): https://codereview.chromium.org/1993173002/diff/1/media/cast/sender/audio_encoder.cc#oldcode471 media/cast/sender/audio_encoder.cc:471: const_cast<bool&>(can_resume_) = can_resume != 0; On 2016/05/19 17:21:41, hubbe ...
4 years, 7 months ago (2016-05-19 18:10:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993173002/1
4 years, 7 months ago (2016-05-19 18:11:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 18:17:34 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 18:20:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93c899178a3c2c46ce9cac2c9da2134d81cb4f94
Cr-Commit-Position: refs/heads/master@{#394816}

Powered by Google App Engine
This is Rietveld 408576698