Chromium Code Reviews

Issue 1991763002: Remove LayoutBlock::deleteLineBoxTree(). (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
wkorman, eae, szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove LayoutBlock::deleteLineBoxTree(). The one in LayoutBlockFlow is all we need now. BUG=302024 Committed: https://crrev.com/f61b0f63671e58c6636ac6a6310b1b2c8d1cb23e Cr-Commit-Position: refs/heads/master@{#394467}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+12 lines, -19 lines)
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +0 lines, -3 lines 0 comments
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +0 lines, -5 lines 0 comments
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +1 line, -1 line 0 comments
M third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp View 1 chunk +2 lines, -1 line 0 comments
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 chunk +6 lines, -6 lines 0 comments
M third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp View 1 chunk +2 lines, -2 lines 0 comments
M third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-18 12:32:42 UTC) #2
eae
Awesome! Thanks for doing this, so much cleaner now. LGTM
4 years, 7 months ago (2016-05-18 17:57:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991763002/1
4 years, 7 months ago (2016-05-18 17:57:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 18:05:36 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 18:07:40 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f61b0f63671e58c6636ac6a6310b1b2c8d1cb23e
Cr-Commit-Position: refs/heads/master@{#394467}

Powered by Google App Engine