third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp - Issue 1991763002: Remove LayoutBlock::deleteLineBoxTree().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp

Issue 1991763002: Remove LayoutBlock::deleteLineBoxTree(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp b/third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp

index 9a2eb8b4f827f0f31434e452d2404467bf359546..33723bef1fa38aa8f959144541e95b2ad366727b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp

@@ -119,8 +119,8 @@ void LayoutRubyBase::moveBlockChildren(LayoutRubyBase* toBase, LayoutObject* bef

LayoutObject* lastChildThere = toBase->lastChild();

if (firstChildHere->isAnonymousBlock() && firstChildHere->childrenInline()

&& lastChildThere && lastChildThere->isAnonymousBlock() && lastChildThere->childrenInline()) {

- LayoutBlock* anonBlockHere = toLayoutBlock(firstChildHere);

- LayoutBlock* anonBlockThere = toLayoutBlock(lastChildThere);

+ LayoutBlockFlow* anonBlockHere = toLayoutBlockFlow(firstChildHere);

+ LayoutBlockFlow* anonBlockThere = toLayoutBlockFlow(lastChildThere);

anonBlockHere->moveAllChildrenTo(anonBlockThere, anonBlockThere->children());

anonBlockHere->deleteLineBoxTree();

anonBlockHere->destroy();