third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp - Issue 1991763002: Remove LayoutBlock::deleteLineBoxTree().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

Issue 1991763002: Remove LayoutBlock::deleteLineBoxTree(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp b/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

index 9d8802674bd23e2c141bd0c45cd17cd60d8d0172..9c625c6a370943b2db6b8acc6cb19cdbee543279 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

@@ -137,7 +137,8 @@ LayoutObject* LayoutFullScreen::wrapLayoutObject(LayoutObject* object, LayoutObj

ASSERT(containingBlock);

// Since we are moving the |object| to a new parent |fullscreenLayoutObject|,

// the line box tree underneath our |containingBlock| is not longer valid.

- containingBlock->deleteLineBoxTree();

+ if (containingBlock->isLayoutBlockFlow())

+ toLayoutBlockFlow(containingBlock)->deleteLineBoxTree();

parent->addChildWithWritingModeOfParent(fullscreenLayoutObject, object);

object->remove();