Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 1991763002: Remove LayoutBlock::deleteLineBoxTree(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 RootInlineBox* firstRootBox() const { return static_cast<RootInlineBox*>(fir stLineBox()); } 144 RootInlineBox* firstRootBox() const { return static_cast<RootInlineBox*>(fir stLineBox()); }
145 RootInlineBox* lastRootBox() const { return static_cast<RootInlineBox*>(last LineBox()); } 145 RootInlineBox* lastRootBox() const { return static_cast<RootInlineBox*>(last LineBox()); }
146 146
147 // Insert a child correctly into the tree when |beforeDescendant| isn't a di rect child of 147 // Insert a child correctly into the tree when |beforeDescendant| isn't a di rect child of
148 // |this|. This happens e.g. when there's an anonymous block child of |this| and 148 // |this|. This happens e.g. when there's an anonymous block child of |this| and
149 // |beforeDescendant| has been reparented into that one. Such things are inv isible to the DOM, 149 // |beforeDescendant| has been reparented into that one. Such things are inv isible to the DOM,
150 // and addChild() is typically called with the DOM tree (and not the layout tree) in mind. 150 // and addChild() is typically called with the DOM tree (and not the layout tree) in mind.
151 void addChildBeforeDescendant(LayoutObject* newChild, LayoutObject* beforeDe scendant); 151 void addChildBeforeDescendant(LayoutObject* newChild, LayoutObject* beforeDe scendant);
152 152
153 public: 153 public:
154 // FIXME-BLOCKFLOW: Remove virtualizaion when all callers have moved to Layo utBlockFlow
155 virtual void deleteLineBoxTree();
156
157 void addChild(LayoutObject* newChild, LayoutObject* beforeChild = nullptr) o verride; 154 void addChild(LayoutObject* newChild, LayoutObject* beforeChild = nullptr) o verride;
158 155
159 virtual void layoutBlock(bool relayoutChildren); 156 virtual void layoutBlock(bool relayoutChildren);
160 157
161 void insertPositionedObject(LayoutBox*); 158 void insertPositionedObject(LayoutBox*);
162 static void removePositionedObject(LayoutBox*); 159 static void removePositionedObject(LayoutBox*);
163 void removePositionedObjects(LayoutBlock*, ContainingBlockState = SameContai ningBlock); 160 void removePositionedObjects(LayoutBlock*, ContainingBlockState = SameContai ningBlock);
164 161
165 TrackedLayoutBoxListHashSet* positionedObjects() const { return hasPositione dObjects() ? positionedObjectsInternal() : nullptr; } 162 TrackedLayoutBoxListHashSet* positionedObjects() const { return hasPositione dObjects() ? positionedObjectsInternal() : nullptr; }
166 bool hasPositionedObjects() const 163 bool hasPositionedObjects() const
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
466 // FIXME: This is temporary as we move code that accesses block flow 463 // FIXME: This is temporary as we move code that accesses block flow
467 // member variables out of LayoutBlock and into LayoutBlockFlow. 464 // member variables out of LayoutBlock and into LayoutBlockFlow.
468 friend class LayoutBlockFlow; 465 friend class LayoutBlockFlow;
469 }; 466 };
470 467
471 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock()); 468 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlock, isLayoutBlock());
472 469
473 } // namespace blink 470 } // namespace blink
474 471
475 #endif // LayoutBlock_h 472 #endif // LayoutBlock_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698