Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1991713002: Adding ia32 simd assembler changes. (Closed)

Created:
4 years, 7 months ago by bradnelson
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adding ia32 simd assembler support. Based on assembler changes from this patch: https://codereview.chromium.org/90643003/ BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4124 R=titzer@chromium.org LOG=N Committed: https://crrev.com/fbf58a5af1d07a7fbb3763aa15f8ba26e2ce7d11 Cr-Commit-Position: refs/heads/master@{#36349}

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -19 lines) Patch
M src/ia32/assembler-ia32.h View 1 5 chunks +49 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.cc View 1 2 chunks +193 lines, -0 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 1 7 chunks +82 lines, -18 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 3 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
bradnelson
Not really for review yet as I want to do a cleanup pass and check ...
4 years, 7 months ago (2016-05-18 08:01:06 UTC) #3
bradnelson
4 years, 7 months ago (2016-05-18 08:01:44 UTC) #5
titzer
On 2016/05/18 08:01:44, bradnelson wrote: lgtm other than small comments
4 years, 7 months ago (2016-05-18 09:52:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991713002/20001
4 years, 7 months ago (2016-05-19 07:37:46 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 08:03:09 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fbf58a5af1d07a7fbb3763aa15f8ba26e2ce7d11 Cr-Commit-Position: refs/heads/master@{#36349}
4 years, 7 months ago (2016-05-19 08:04:20 UTC) #15
Michael Achenbach
4 years, 7 months ago (2016-05-19 08:57:44 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1992163002/ by machenbach@chromium.org.

The reason for reverting is: Crashes on win32 debug:
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds...

Also, would be nice if the test output could be a bit shorter and only print
what's necessary to trace a failure. Or split things into more smaller tests.
Like that, these logs must be processed, json-encoded/decoded and sent around
through the infrastructure.

Some chars in the output make the json encoder unhappy, therefore the
infrastructure can't nicely display the failures..

Powered by Google App Engine
This is Rietveld 408576698