[Findit] Send targeted_tests to try-job in build_parameter instend of build_property (Findit side).

[Findit] Send targeted_tests to try-job in build_parameter instend of build_property.

When the test list exceeds the 1024 char limit it will raise an exception and the try job won't start. Send tests as build_parameter instead to avoid this limit.

BUG=612979
Committed: https://chromium.googlesource.com/infra/infra/+/b0e4f1b8847a1000c25c97bab59005d505049270

[chanli, 2016-05-19 21:15:38]

Description was changed from

==========
[Findit] Send targeted_tests to try-job in build_parameter instend of
build_property.

When the test list exceeds the 1024 char limit it will raise an exception and
the try job won't start. Send tests as build_parameter instead to avoid this
limit.

BUG=612979
==========

to

==========
[Findit] Send targeted_tests to try-job in build_parameter instend of
build_property.

When the test list exceeds the 1024 char limit it will raise an exception and
the try job won't start. Send tests as build_parameter instead to avoid this
limit.

BUG=612979
==========

[chanli, 2016-05-19 21:16:16]

PTAL.

Recipe side change coming soon.

[chanli, 2016-05-20 05:11:00]

chanli@chromium.org changed reviewers:
+ lijeffrey@chromium.org, stgao@chromium.org

[stgao, 2016-05-20 05:15:49]

https://codereview.chromium.org/1991333002/diff/1/appengine/findit/common/wat...
File appengine/findit/common/waterfall/buildbucket_client.py (right):

https://codereview.chromium.org/1991333002/diff/1/appengine/findit/common/wat...
appengine/findit/common/waterfall/buildbucket_client.py:37: ('master_name',
'builder_name', 'revision', 'properties', 'tags', 'tests'))
How about making this generic enough for other change too? Now it is the list of
tests, but later we might have to move other properties or add some new ones
too.

[stgao, 2016-05-20 18:34:36]

lgtm

https://codereview.chromium.org/1991333002/diff/20001/appengine/findit/common...
File appengine/findit/common/waterfall/buildbucket_client.py (right):

https://codereview.chromium.org/1991333002/diff/20001/appengine/findit/common...
appengine/findit/common/waterfall/buildbucket_client.py:38:
'additional_parameters'))
nit: "build_parameters" to be more clear and to match with for build properties?

[lijeffrey, 2016-05-20 20:44:41]

lgtm

https://codereview.chromium.org/1991333002/diff/1/appengine/findit/waterfall/...
File appengine/findit/waterfall/schedule_try_job_pipeline.py (right):

https://codereview.chromium.org/1991333002/diff/1/appengine/findit/waterfall/...
appengine/findit/waterfall/schedule_try_job_pipeline.py:56: targeted_tests = {}
nit: add 1 newline after this

[chanli, 2016-05-20 20:52:55]

https://codereview.chromium.org/1991333002/diff/20001/appengine/findit/common...
File appengine/findit/common/waterfall/buildbucket_client.py (right):

https://codereview.chromium.org/1991333002/diff/20001/appengine/findit/common...
appengine/findit/common/waterfall/buildbucket_client.py:38:
'additional_parameters'))
On 2016/05/20 18:34:36, stgao wrote:
> nit: "build_parameters" to be more clear and to match with for build
properties?

the entire 'parameters_json' represents actually build parameters(See
https://docs.google.com/document/d/10BH6oSq_UEtdSdhrguEuV4hx-JxY7jzFcgs1OCHcn...).
I can change it to additional_build_parameters if that's more clear.

[chanli, 2016-05-20 21:09:47]

The CQ bit was checked by chanli@chromium.org

[chanli, 2016-05-20 21:09:48]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org,
lijeffrey@chromium.org
Link to the patchset: https://codereview.chromium.org/1991333002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-05-20 21:09:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1991333002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1991333002/40001

[commit-bot: I haz the power, 2016-05-20 21:14:21]

Description was changed from

==========
[Findit] Send targeted_tests to try-job in build_parameter instend of
build_property.

When the test list exceeds the 1024 char limit it will raise an exception and
the try job won't start. Send tests as build_parameter instead to avoid this
limit.

BUG=612979
==========

to

==========
[Findit] Send targeted_tests to try-job in build_parameter instend of
build_property.

When the test list exceeds the 1024 char limit it will raise an exception and
the try job won't start. Send tests as build_parameter instead to avoid this
limit.

BUG=612979

Committed:
https://chromium.googlesource.com/infra/infra/+/b0e4f1b8847a1000c25c97bab5900...
==========

[commit-bot: I haz the power, 2016-05-20 21:14:22]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/b0e4f1b8847a1000c25c97bab5900...