appengine/findit/waterfall/schedule_try_job_pipeline.py - Issue 1991333002: [Findit] Send targeted_tests to try-job in build_parameter instend of build_property (Findit side).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/schedule_try_job_pipeline.py

Issue 1991333002: [Findit] Send targeted_tests to try-job in build_parameter instend of build_property (Findit side). (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: . Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/common/waterfall/test/buildbucket_client_test.py ('k') | appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/schedule_try_job_pipeline.py

diff --git a/appengine/findit/waterfall/schedule_try_job_pipeline.py b/appengine/findit/waterfall/schedule_try_job_pipeline.py

index e157d7a36b3c8494fb4be6408acdf1375d13952f..44971c500e67b5ef85c7f8be71fabcd726217eaa 100644

--- a/appengine/findit/waterfall/schedule_try_job_pipeline.py

+++ b/appengine/findit/waterfall/schedule_try_job_pipeline.py

@@ -17,8 +17,7 @@ class ScheduleTryJobPipeline(BasePipeline):

def _GetBuildProperties(

self, master_name, builder_name, build_number, good_revision,

- bad_revision, try_job_type, compile_targets, targeted_tests,

- suspected_revisions):

+ bad_revision, try_job_type, compile_targets, suspected_revisions):

properties = {

'recipe': 'findit/chromium/%s' % try_job_type,

'good_revision': good_revision,

@@ -34,8 +33,6 @@ class ScheduleTryJobPipeline(BasePipeline):

properties['compile_targets'] = compile_targets

else: # try_job_type is 'test'.

properties['target_testername'] = builder_name

- assert targeted_tests

- properties['tests'] = targeted_tests

if suspected_revisions:

properties['suspected_revisions'] = suspected_revisions

@@ -53,10 +50,16 @@ class ScheduleTryJobPipeline(BasePipeline):

properties = self._GetBuildProperties(

master_name, builder_name, build_number, good_revision, bad_revision,

- try_job_type, compile_targets, targeted_tests, suspected_revisions)

+ try_job_type, compile_targets, suspected_revisions)

+ if try_job_type == TryJobType.COMPILE:

+ additional_parameters = {}

+ else:

+ additional_parameters = {'tests': targeted_tests}

try_job = buildbucket_client.TryJob(

- tryserver_mastername, tryserver_buildername, None, properties, [])

+ tryserver_mastername, tryserver_buildername, None, properties,

+ additional_parameters, [])

error, build = buildbucket_client.TriggerTryJobs([try_job])[0]

if error: # pragma: no cover