Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py

Issue 1991333002: [Findit] Send targeted_tests to try-job in build_parameter instend of build_property (Findit side). (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: . Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « appengine/findit/waterfall/schedule_try_job_pipeline.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from common.waterfall import buildbucket_client 5 from common.waterfall import buildbucket_client
6 from model.wf_try_job import WfTryJob 6 from model.wf_try_job import WfTryJob
7 from model.wf_try_job_data import WfTryJobData 7 from model.wf_try_job_data import WfTryJobData
8 from waterfall.schedule_try_job_pipeline import ScheduleTryJobPipeline 8 from waterfall.schedule_try_job_pipeline import ScheduleTryJobPipeline
9 from waterfall.test import wf_testcase 9 from waterfall.test import wf_testcase
10 from waterfall.try_job_type import TryJobType 10 from waterfall.try_job_type import TryJobType
(...skipping 27 matching lines...) Expand all
38 'target_mastername': master_name, 38 'target_mastername': master_name,
39 'target_buildername': 'b', 39 'target_buildername': 'b',
40 'compile_targets': compile_targets, 40 'compile_targets': compile_targets,
41 'referenced_build_url': ('https://build.chromium.org/p/%s/builders' 41 'referenced_build_url': ('https://build.chromium.org/p/%s/builders'
42 '/%s/builds/%s') % ( 42 '/%s/builds/%s') % (
43 master_name, builder_name, build_number) 43 master_name, builder_name, build_number)
44 } 44 }
45 try_job_pipeline = ScheduleTryJobPipeline() 45 try_job_pipeline = ScheduleTryJobPipeline()
46 properties = try_job_pipeline._GetBuildProperties( 46 properties = try_job_pipeline._GetBuildProperties(
47 master_name, builder_name, build_number, 1, 2, TryJobType.COMPILE, 47 master_name, builder_name, build_number, 1, 2, TryJobType.COMPILE,
48 compile_targets, None, None) 48 compile_targets, None)
49 49
50 self.assertEqual(properties, expected_properties) 50 self.assertEqual(properties, expected_properties)
51 51
52 def testGetBuildPropertiesForTestFailure(self): 52 def testGetBuildPropertiesForTestFailure(self):
53 master_name = 'm' 53 master_name = 'm'
54 builder_name = 'b' 54 builder_name = 'b'
55 build_number = 1 55 build_number = 1
56 targeted_tests = {'a': []}
57 56
58 expected_properties = { 57 expected_properties = {
59 'recipe': 'findit/chromium/test', 58 'recipe': 'findit/chromium/test',
60 'good_revision': 1, 59 'good_revision': 1,
61 'bad_revision': 2, 60 'bad_revision': 2,
62 'target_mastername': master_name, 61 'target_mastername': master_name,
63 'target_testername': 'b', 62 'target_testername': 'b',
64 'tests': targeted_tests,
65 'referenced_build_url': ('https://build.chromium.org/p/%s/builders' 63 'referenced_build_url': ('https://build.chromium.org/p/%s/builders'
66 '/%s/builds/%s') % ( 64 '/%s/builds/%s') % (
67 master_name, builder_name, build_number) 65 master_name, builder_name, build_number)
68 } 66 }
69 try_job_pipeline = ScheduleTryJobPipeline() 67 try_job_pipeline = ScheduleTryJobPipeline()
70 properties = try_job_pipeline._GetBuildProperties( 68 properties = try_job_pipeline._GetBuildProperties(
71 master_name, builder_name, build_number, 1, 2, TryJobType.TEST, 69 master_name, builder_name, build_number, 1, 2, TryJobType.TEST,
72 None, targeted_tests, None) 70 None, None)
73 71
74 self.assertEqual(properties, expected_properties) 72 self.assertEqual(properties, expected_properties)
75 73
76 def testSuccessfullyScheduleNewTryJobForCompileWithSuspectedRevisions(self): 74 def testSuccessfullyScheduleNewTryJobForCompileWithSuspectedRevisions(self):
77 master_name = 'm' 75 master_name = 'm'
78 builder_name = 'b' 76 builder_name = 'b'
79 build_number = 223 77 build_number = 223
80 good_revision = 'rev1' 78 good_revision = 'rev1'
81 bad_revision = 'rev2' 79 bad_revision = 'rev2'
82 build_id = '1' 80 build_id = '1'
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 try_job_data = WfTryJobData.Get(try_job_id) 146 try_job_data = WfTryJobData.Get(try_job_id)
149 self.assertEqual(try_job_id, build_id) 147 self.assertEqual(try_job_id, build_id)
150 self.assertEqual(try_job.test_results[-1]['try_job_id'], build_id) 148 self.assertEqual(try_job.test_results[-1]['try_job_id'], build_id)
151 self.assertIsNotNone(try_job_data) 149 self.assertIsNotNone(try_job_data)
152 self.assertEqual(try_job_data.master_name, master_name) 150 self.assertEqual(try_job_data.master_name, master_name)
153 self.assertEqual(try_job_data.builder_name, builder_name) 151 self.assertEqual(try_job_data.builder_name, builder_name)
154 self.assertEqual(try_job_data.build_number, build_number) 152 self.assertEqual(try_job_data.build_number, build_number)
155 self.assertEqual(try_job_data.try_job_type, TryJobType.TEST) 153 self.assertEqual(try_job_data.try_job_type, TryJobType.TEST)
156 self.assertFalse(try_job_data.has_compile_targets) 154 self.assertFalse(try_job_data.has_compile_targets)
157 self.assertFalse(try_job_data.has_heuristic_results) 155 self.assertFalse(try_job_data.has_heuristic_results)
OLDNEW
« no previous file with comments | « appengine/findit/waterfall/schedule_try_job_pipeline.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698