Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1933)

Unified Diff: appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py

Issue 1991333002: [Findit] Send targeted_tests to try-job in build_parameter instend of build_property (Findit side). (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: . Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/waterfall/schedule_try_job_pipeline.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py b/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py
index 9a5857befa7190acd11367d0e7401d4499e7b416..31dfd13907eaa86c6b4460702d1579b5b8501709 100644
--- a/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py
+++ b/appengine/findit/waterfall/test/schedule_try_job_pipeline_test.py
@@ -45,7 +45,7 @@ class ScheduleTryjobPipelineTest(wf_testcase.WaterfallTestCase):
try_job_pipeline = ScheduleTryJobPipeline()
properties = try_job_pipeline._GetBuildProperties(
master_name, builder_name, build_number, 1, 2, TryJobType.COMPILE,
- compile_targets, None, None)
+ compile_targets, None)
self.assertEqual(properties, expected_properties)
@@ -53,7 +53,6 @@ class ScheduleTryjobPipelineTest(wf_testcase.WaterfallTestCase):
master_name = 'm'
builder_name = 'b'
build_number = 1
- targeted_tests = {'a': []}
expected_properties = {
'recipe': 'findit/chromium/test',
@@ -61,7 +60,6 @@ class ScheduleTryjobPipelineTest(wf_testcase.WaterfallTestCase):
'bad_revision': 2,
'target_mastername': master_name,
'target_testername': 'b',
- 'tests': targeted_tests,
'referenced_build_url': ('https://build.chromium.org/p/%s/builders'
'/%s/builds/%s') % (
master_name, builder_name, build_number)
@@ -69,7 +67,7 @@ class ScheduleTryjobPipelineTest(wf_testcase.WaterfallTestCase):
try_job_pipeline = ScheduleTryJobPipeline()
properties = try_job_pipeline._GetBuildProperties(
master_name, builder_name, build_number, 1, 2, TryJobType.TEST,
- None, targeted_tests, None)
+ None, None)
self.assertEqual(properties, expected_properties)
« no previous file with comments | « appengine/findit/waterfall/schedule_try_job_pipeline.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698