chrome/browser/extensions/extension_tab_util.cc - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tab_util.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: "" -> std::string() Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_tab_util.cc

diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc

index 68a27d537c29618d7377c406f8d11c37e2ded727..68d6fe0f98a1331832d37f37e2582ec49485859e 100644

--- a/chrome/browser/extensions/extension_tab_util.cc

+++ b/chrome/browser/extensions/extension_tab_util.cc

@@ -349,10 +349,10 @@ std::unique_ptr<api::tabs::Tab> ExtensionTabUtil::CreateTabObject(

return result;

}

-base::ListValue* ExtensionTabUtil::CreateTabList(

+std::unique_ptr<base::ListValue> ExtensionTabUtil::CreateTabList(

const Browser* browser,

const Extension* extension) {

- base::ListValue* tab_list = new base::ListValue();

+ std::unique_ptr<base::ListValue> tab_list(new base::ListValue());

TabStripModel* tab_strip = browser->tab_strip_model();

for (int i = 0; i < tab_strip->count(); ++i) {

tab_list->Append(