Remove ExtensionFunction::SetResult(T*) overload.

chrome/browser/extensions/extension_tab_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_tab_util.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 331 matching lines @@
   if (controller &&
       (!extension || controller->IsVisibleToExtension(extension))) {
     return controller->CreateTabObject(extension, tab_index);
   }
   std::unique_ptr<api::tabs::Tab> result =
       CreateTabObject(contents, tab_strip, tab_index);
   ScrubTabForExtension(extension, contents, result.get());
   return result;
 }
 
-base::ListValue* ExtensionTabUtil::CreateTabList(
+std::unique_ptr<base::ListValue> ExtensionTabUtil::CreateTabList(
     const Browser* browser,
     const Extension* extension) {
-  base::ListValue* tab_list = new base::ListValue();
+  std::unique_ptr<base::ListValue> tab_list(new base::ListValue());
   TabStripModel* tab_strip = browser->tab_strip_model();
   for (int i = 0; i < tab_strip->count(); ++i) {
     tab_list->Append(
         CreateTabObject(tab_strip->GetWebContentsAt(i), tab_strip, i, extension)
             ->ToValue()
             .release());

[Lei Zhang, 2016/05/19 07:21:33]

BTW, switch to the unique_ptr version at some point?

[dcheng, 2016/05/19 07:34:25]

Yes, I'm intentionally limiting the scope of my changes. But this will come in a
followup when ListValue::Append(T*) is removed.

   }
 
   return tab_list;
 }
 
 // static
 std::unique_ptr<api::tabs::Tab> ExtensionTabUtil::CreateTabObject(
     content::WebContents* contents,
     TabStripModel* tab_strip,
     int tab_index) {
@@ skipping 292 matching lines @@
   chrome::ShowSingletonTabOverwritingNTP(browser, params);
   return true;
 }
 
 // static
 bool ExtensionTabUtil::BrowserSupportsTabs(Browser* browser) {
   return browser && browser->tab_strip_model() && !browser->is_devtools();
 }
 
 }  // namespace extensions