Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/window_controller.h

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: "" -> std::string() Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/extension_tab_util.cc ('K') | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/browser/extensions/window_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/window_controller.h
diff --git a/chrome/browser/extensions/window_controller.h b/chrome/browser/extensions/window_controller.h
index 3a2673f9277ae957971983d3642324d08736facc..deb33191816ec8c652593a53c0869fcc06e7f373 100644
--- a/chrome/browser/extensions/window_controller.h
+++ b/chrome/browser/extensions/window_controller.h
@@ -80,10 +80,10 @@ class WindowController {
// Populates a dictionary for the Window object. Override this to set
// implementation specific properties (call the base implementation first to
// set common properties).
- virtual base::DictionaryValue* CreateWindowValue() const;
+ std::unique_ptr<base::DictionaryValue> CreateWindowValue() const;
// Populates a dictionary for the Window object, including a list of tabs.
- virtual base::DictionaryValue* CreateWindowValueWithTabs(
+ virtual std::unique_ptr<base::DictionaryValue> CreateWindowValueWithTabs(
const extensions::Extension* extension) const = 0;
virtual std::unique_ptr<api::tabs::Tab> CreateTabObject(
« chrome/browser/extensions/extension_tab_util.cc ('K') | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/browser/extensions/window_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698