chrome/browser/chromeos/extensions/wallpaper_api.cc - Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/wallpaper_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: "" -> std::string() Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/extensions/wallpaper_api.cc

diff --git a/chrome/browser/chromeos/extensions/wallpaper_api.cc b/chrome/browser/chromeos/extensions/wallpaper_api.cc

index 5d16b287c3c909dd3ea118be8f87fa37374fa797..c0ae6e8cda796578d75e07a030d50deda1df9f87 100644

--- a/chrome/browser/chromeos/extensions/wallpaper_api.cc

+++ b/chrome/browser/chromeos/extensions/wallpaper_api.cc

@@ -236,7 +236,7 @@ void WallpaperSetWallpaperFunction::ThumbnailGenerated(

thumbnail_data->size());

if (params_->details.thumbnail) {

- SetResult(thumbnail_result);

+ SetResult(base::WrapUnique(thumbnail_result));

Lei Zhang 2016/05/19 07:21:33 #include ptr_util.h and <memory> ?

dcheng 2016/05/19 07:34:25 Done, though <memory> is in the 'associated' heade

SendResponse(true);

}