Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 1990893002: Revert of Add OpenGL context to Viewer. (Closed)

Created:
4 years, 7 months ago by jvanverth1
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add OpenGL context to Viewer. (patchset #7 id:120001 of https://codereview.chromium.org/1978573003/ ) Reason for revert: sk_app/WindowContext.cpp is missing. Need to add file and resubmit. Original issue's description: > Add OpenGL context to Viewer. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978573003 > > Committed: https://skia.googlesource.com/skia/+/56a11e4d6f3d436a3c2497c9c9e71a117d78a93f TBR=brianosman@google.com,bsalomon@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2884e9c0bd2cc9634a4b932d4142840c67227a78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -447 lines) Patch
M src/gpu/vk/GrVkBuffer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/viewer/Viewer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/viewer/Viewer.cpp View 5 chunks +2 lines, -24 lines 0 comments Download
M tools/viewer/sk_app/DisplayParams.h View 1 chunk +3 lines, -5 lines 0 comments Download
D tools/viewer/sk_app/GLWindowContext.h View 1 chunk +0 lines, -63 lines 0 comments Download
D tools/viewer/sk_app/GLWindowContext.cpp View 1 chunk +0 lines, -112 lines 0 comments Download
M tools/viewer/sk_app/VulkanWindowContext.h View 4 chunks +16 lines, -10 lines 0 comments Download
M tools/viewer/sk_app/VulkanWindowContext.cpp View 8 chunks +10 lines, -21 lines 0 comments Download
M tools/viewer/sk_app/Window.h View 1 chunk +3 lines, -8 lines 0 comments Download
M tools/viewer/sk_app/Window.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M tools/viewer/sk_app/WindowContext.h View 1 chunk +5 lines, -29 lines 0 comments Download
M tools/viewer/sk_app/android/Window_android.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/viewer/sk_app/android/Window_android.cpp View 1 chunk +1 line, -1 line 0 comments Download
D tools/viewer/sk_app/win/GLWindowContext_win.h View 1 chunk +0 lines, -37 lines 0 comments Download
D tools/viewer/sk_app/win/GLWindowContext_win.cpp View 1 chunk +0 lines, -110 lines 0 comments Download
A tools/viewer/sk_app/win/VulkanWindowContext_win.h View 1 chunk +28 lines, -0 lines 0 comments Download
M tools/viewer/sk_app/win/VulkanWindowContext_win.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tools/viewer/sk_app/win/Window_win.h View 2 chunks +1 line, -7 lines 0 comments Download
M tools/viewer/sk_app/win/Window_win.cpp View 2 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jvanverth1
Created Revert of Add OpenGL context to Viewer.
4 years, 7 months ago (2016-05-18 14:01:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1990893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1990893002/1
4 years, 7 months ago (2016-05-18 14:01:10 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 14:01:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2884e9c0bd2cc9634a4b932d4142840c67227a78

Powered by Google App Engine
This is Rietveld 408576698