Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1989623002: Suppressed MEs for gestures from cancelled PEs (Closed)

Created:
4 years, 7 months ago by mustaq
Modified:
4 years, 5 months ago
CC:
chromium-reviews, dtapuska+blinkwatch_chromium.org, tdresser+watch_chromium.org, eae+blinkwatch, jam, dtapuska+chromiumwatch_chromium.org, blink-reviews-events_chromium.org, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org, wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppressed MEs for gestures from cancelled PEs Our current implementation suppresses the touch-points for which the pointerevents have been canceled, to mimic the ME suppression behavior of PointerEvents. In Edge, however, TEs are fired as-is without considering the canceling status of pointerdowns. We need to follow the Edge behavior here for better web-compat. Moreover, since preventing a pointerdown suppresses MEs, this should be true for the MEs from gestures that are ultimately triggered by TEs, when the PEs corresponding to the TEs are canceled (crbug.com/606938). In addition, the current implementation (suppressing touch-points for canceled pointerevents) has a few bad side-effects: - TE sequence can become inconsistent (eg touchend w/o toushstart) for certain sequences of PE canceling (crbug.com/607588). - Preventing all PEs completely hides TEs but until touch scroll starts, which suppresses PEs only to "reveal" the hidden TE sequence from "middle" (crbug.com/507408). This CL adds a unique-touch-id queue in PointerEventManager to properly suppress MEs from GestureTap, and makes TE firing independent of PE handling in JS. This CL also suppresses some default behavior associated with a tap on canceled pointerdowns (e.g. focusing an input field). The MEs from GestureLongPress are left as-is in this CL because suppressing them could break drag-drop; this will be done separately in a follow-up CL. BUG=606938, 607588, 507408 Committed: https://crrev.com/1904837ebb6f8f352572e0f833e14640a0db6d54 Cr-Commit-Position: refs/heads/master@{#400264}

Patch Set 1 #

Patch Set 2 : Added Blink bookkeeping. #

Patch Set 3 : Removed browser-side plumbing, added tests. #

Total comments: 19

Patch Set 4 : Added queue timestamp in Blink. #

Patch Set 5 : Brought back unique-id plumbing, nuked queued timestamp #

Patch Set 6 : Fixed a comment. #

Total comments: 8

Patch Set 7 : Rebased. #

Total comments: 6

Patch Set 8 : #

Patch Set 9 : Addressed most comments. #

Patch Set 10 : Plumbed aura gestures, fixed unittests. #

Total comments: 2

Patch Set 11 : Fixed packet unittest. #

Patch Set 12 : #

Patch Set 13 : Updated comments, cleaned event.h interface. #

Patch Set 14 : Fixed a text selection regression. #

Total comments: 11

Patch Set 15 : #

Total comments: 2

Patch Set 16 : Addressed final comments. #

Patch Set 17 : Merge conflicts for Aura #

Patch Set 18 : Rebased, added debug dump #

Patch Set 19 : Debug UGI #

Patch Set 20 : Fixed event_sender parsing order in Windows. #

Patch Set 21 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+563 lines, -134 lines) Patch
M components/test_runner/event_sender.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +5 lines, -2 lines 0 comments Download
M components/test_runner/event_sender.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 5 chunks +37 lines, -43 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_util_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/ui_events_helper.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +3 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointer-mouse.html View 1 2 3 4 1 chunk +114 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointer-mouse-expected.txt View 1 2 3 4 1 chunk +75 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/touch-pointer-events-expected.txt View 1 2 chunks +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/touch-pointer-mouse-expected.txt View 1 2 3 4 1 chunk +87 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/touch-pointercancel-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 10 chunks +40 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.h View 1 2 3 4 5 6 3 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 1 2 3 4 5 6 7 4 chunks +32 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/input/TouchEventManager.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/TouchEventManager.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 18 19 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/PlatformGestureEvent.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/PlatformTouchEvent.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEvent.cpp View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 1 2 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp View 1 2 3 4 5 6 7 8 9 4 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebInputEvent.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +11 lines, -1 line 0 comments Download
M ui/events/blink/blink_event_util.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/blink/blink_event_util.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +6 lines, -2 lines 0 comments Download
M ui/events/blink/blink_event_util_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/event.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +15 lines, -1 line 0 comments Download
M ui/events/event.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +4 lines, -2 lines 0 comments Download
M ui/events/gesture_detection/gesture_event_data.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +7 lines, -1 line 0 comments Download
M ui/events/gesture_detection/gesture_event_data.cc View 3 4 4 chunks +8 lines, -4 lines 0 comments Download
M ui/events/gesture_detection/gesture_event_data_packet.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/gesture_event_data_packet.cc View 1 2 3 4 5 6 7 8 9 2 chunks +6 lines, -3 lines 0 comments Download
M ui/events/gesture_detection/gesture_event_data_packet_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +14 lines, -5 lines 0 comments Download
M ui/events/gesture_detection/gesture_provider.cc View 1 2 3 4 5 6 3 chunks +16 lines, -5 lines 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter.cc View 1 2 3 4 5 6 7 4 chunks +19 lines, -9 lines 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gestures/gesture_provider_aura.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gestures/gesture_provider_aura.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 85 (36 generated)
mustaq
ptal. Dropped the uniqueTouchId idea in favor of a simpler solution.
4 years, 6 months ago (2016-05-26 22:16:06 UTC) #6
tdresser
LGTM, this is definitely cleaner. https://codereview.chromium.org/1989623002/diff/60001/third_party/WebKit/Source/core/input/EventHandler.h File third_party/WebKit/Source/core/input/EventHandler.h (right): https://codereview.chromium.org/1989623002/diff/60001/third_party/WebKit/Source/core/input/EventHandler.h#newcode470 third_party/WebKit/Source/core/input/EventHandler.h:470: // firing for the ...
4 years, 6 months ago (2016-05-27 18:26:32 UTC) #7
Rick Byers
Would love to be proven wrong about my concern (or convinced it doesn't matter) :-) ...
4 years, 6 months ago (2016-05-27 20:39:27 UTC) #8
dtapuska
https://codereview.chromium.org/1989623002/diff/60001/third_party/WebKit/Source/core/input/EventHandler.cpp File third_party/WebKit/Source/core/input/EventHandler.cpp (right): https://codereview.chromium.org/1989623002/diff/60001/third_party/WebKit/Source/core/input/EventHandler.cpp#newcode2169 third_party/WebKit/Source/core/input/EventHandler.cpp:2169: m_suppressMouseEventsFromGestures = I see there is an ASSERT in ...
4 years, 6 months ago (2016-05-27 20:54:07 UTC) #10
mustaq
https://codereview.chromium.org/1989623002/diff/60001/third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointer-mouse-expected.txt File third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointer-mouse-expected.txt (right): https://codereview.chromium.org/1989623002/diff/60001/third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointer-mouse-expected.txt#newcode18 third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointer-mouse-expected.txt:18: Received touchend On 2016/05/27 20:39:26, Rick Byers wrote: > ...
4 years, 6 months ago (2016-05-30 15:14:26 UTC) #11
mustaq
ptal. In short, pulled the unique-touch-ids from TouchDispositionGestureFilter to Blink to handle unpaired TE/GE sequences. ...
4 years, 6 months ago (2016-06-02 19:26:27 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989623002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989623002/120001
4 years, 6 months ago (2016-06-02 19:39:28 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/222520) linux_chromium_rel_ng on ...
4 years, 6 months ago (2016-06-02 19:44:09 UTC) #16
dtapuska
lgtm % a few questions https://codereview.chromium.org/1989623002/diff/120001/third_party/WebKit/Source/core/input/PointerEventManager.cpp File third_party/WebKit/Source/core/input/PointerEventManager.cpp (right): https://codereview.chromium.org/1989623002/diff/120001/third_party/WebKit/Source/core/input/PointerEventManager.cpp#newcode784 third_party/WebKit/Source/core/input/PointerEventManager.cpp:784: while (!m_touchIdsForCanceledPointerdowns.isEmpty()) { Can ...
4 years, 6 months ago (2016-06-03 15:02:11 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989623002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989623002/140001
4 years, 6 months ago (2016-06-03 15:05:44 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/15854)
4 years, 6 months ago (2016-06-03 15:12:42 UTC) #21
Rick Byers
The approach seems reasonable to me (it's unfortunate that we need this complexity, but we've ...
4 years, 6 months ago (2016-06-03 15:31:40 UTC) #22
Rick Byers
blink code looks good too, except that I think with core now depending on these ...
4 years, 6 months ago (2016-06-03 16:20:45 UTC) #23
Rick Byers
On 2016/06/03 15:31:40, Rick Byers wrote: > The approach seems reasonable to me (it's unfortunate ...
4 years, 6 months ago (2016-06-03 16:34:06 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989623002/160001
4 years, 6 months ago (2016-06-03 19:03:54 UTC) #26
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/76342)
4 years, 6 months ago (2016-06-03 19:23:06 UTC) #28
mustaq
https://codereview.chromium.org/1989623002/diff/120001/third_party/WebKit/Source/core/input/PointerEventManager.cpp File third_party/WebKit/Source/core/input/PointerEventManager.cpp (right): https://codereview.chromium.org/1989623002/diff/120001/third_party/WebKit/Source/core/input/PointerEventManager.cpp#newcode784 third_party/WebKit/Source/core/input/PointerEventManager.cpp:784: while (!m_touchIdsForCanceledPointerdowns.isEmpty()) { On 2016/06/03 15:02:11, dtapuska wrote: > ...
4 years, 6 months ago (2016-06-03 20:34:45 UTC) #29
mustaq
On 2016/06/03 16:34:06, Rick Byers wrote: > Oh I see now that CreateWebGestureEventFromGestureEventData plumbs it ...
4 years, 6 months ago (2016-06-03 21:04:06 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989623002/200001
4 years, 6 months ago (2016-06-08 19:32:04 UTC) #32
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/225483)
4 years, 6 months ago (2016-06-08 20:15:35 UTC) #34
mustaq
ptal, Aura gesture path is now fixed.
4 years, 6 months ago (2016-06-08 20:30:20 UTC) #35
Rick Byers
https://codereview.chromium.org/1989623002/diff/200001/ui/events/event.h File ui/events/event.h (right): https://codereview.chromium.org/1989623002/diff/200001/ui/events/event.h#newcode1056 ui/events/event.h:1056: const GestureEventDetails& details); Should we plan to eliminate this ...
4 years, 6 months ago (2016-06-08 20:42:48 UTC) #36
mustaq
https://codereview.chromium.org/1989623002/diff/200001/ui/events/event.h File ui/events/event.h (right): https://codereview.chromium.org/1989623002/diff/200001/ui/events/event.h#newcode1056 ui/events/event.h:1056: const GestureEventDetails& details); On 2016/06/08 20:42:48, Rick Byers wrote: ...
4 years, 6 months ago (2016-06-08 20:53:17 UTC) #37
Rick Byers
On 2016/06/08 20:53:17, mustaq wrote: > https://codereview.chromium.org/1989623002/diff/200001/ui/events/event.h > File ui/events/event.h (right): > > https://codereview.chromium.org/1989623002/diff/200001/ui/events/event.h#newcode1056 > ...
4 years, 6 months ago (2016-06-08 21:02:05 UTC) #38
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989623002/220001
4 years, 6 months ago (2016-06-08 21:26:05 UTC) #40
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989623002/240001
4 years, 6 months ago (2016-06-08 21:53:40 UTC) #42
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/243532)
4 years, 6 months ago (2016-06-08 23:15:48 UTC) #44
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989623002/280001
4 years, 6 months ago (2016-06-09 15:50:41 UTC) #46
mustaq
ptal: - Fixed all tests. All bots should be green now. - Replaced the overloaded ...
4 years, 6 months ago (2016-06-09 15:52:18 UTC) #47
Rick Byers
LGTM with nits https://codereview.chromium.org/1989623002/diff/280001/third_party/WebKit/Source/core/input/EventHandler.cpp File third_party/WebKit/Source/core/input/EventHandler.cpp (right): https://codereview.chromium.org/1989623002/diff/280001/third_party/WebKit/Source/core/input/EventHandler.cpp#newcode1909 third_party/WebKit/Source/core/input/EventHandler.cpp:1909: WebInputEventResult mouseDownEventResult = WebInputEventResult::NotHandled; nit: this ...
4 years, 6 months ago (2016-06-09 16:07:33 UTC) #48
mustaq
sadrul@chromium.org: Please review changes in ui/events/event.* https://codereview.chromium.org/1989623002/diff/280001/third_party/WebKit/Source/core/input/EventHandler.cpp File third_party/WebKit/Source/core/input/EventHandler.cpp (right): https://codereview.chromium.org/1989623002/diff/280001/third_party/WebKit/Source/core/input/EventHandler.cpp#newcode1909 third_party/WebKit/Source/core/input/EventHandler.cpp:1909: WebInputEventResult mouseDownEventResult = ...
4 years, 6 months ago (2016-06-09 16:41:03 UTC) #51
sadrul
event* lgtm https://codereview.chromium.org/1989623002/diff/280001/ui/events/event.h File ui/events/event.h (right): https://codereview.chromium.org/1989623002/diff/280001/ui/events/event.h#newcode1089 ui/events/event.h:1089: uint32_t unique_touch_event_id_; """The unique id of the ...
4 years, 6 months ago (2016-06-09 16:49:15 UTC) #52
dtapuska
https://codereview.chromium.org/1989623002/diff/280001/third_party/WebKit/Source/core/input/EventHandler.cpp File third_party/WebKit/Source/core/input/EventHandler.cpp (right): https://codereview.chromium.org/1989623002/diff/280001/third_party/WebKit/Source/core/input/EventHandler.cpp#newcode1958 third_party/WebKit/Source/core/input/EventHandler.cpp:1958: if (!m_suppressMouseEventsFromGestures && mouseUpEventResult == WebInputEventResult::NotHandled) On 2016/06/09 16:41:03, ...
4 years, 6 months ago (2016-06-09 16:55:02 UTC) #53
Rick Byers
https://codereview.chromium.org/1989623002/diff/280001/third_party/WebKit/Source/core/input/EventHandler.cpp File third_party/WebKit/Source/core/input/EventHandler.cpp (right): https://codereview.chromium.org/1989623002/diff/280001/third_party/WebKit/Source/core/input/EventHandler.cpp#newcode1909 third_party/WebKit/Source/core/input/EventHandler.cpp:1909: WebInputEventResult mouseDownEventResult = WebInputEventResult::NotHandled; On 2016/06/09 16:41:03, mustaq wrote: ...
4 years, 6 months ago (2016-06-09 17:01:33 UTC) #54
mustaq
https://codereview.chromium.org/1989623002/diff/280001/third_party/WebKit/Source/core/input/EventHandler.cpp File third_party/WebKit/Source/core/input/EventHandler.cpp (right): https://codereview.chromium.org/1989623002/diff/280001/third_party/WebKit/Source/core/input/EventHandler.cpp#newcode1909 third_party/WebKit/Source/core/input/EventHandler.cpp:1909: WebInputEventResult mouseDownEventResult = WebInputEventResult::NotHandled; On 2016/06/09 17:01:33, Rick Byers ...
4 years, 6 months ago (2016-06-09 17:17:28 UTC) #55
sadrul
> https://codereview.chromium.org/1989623002/diff/280001/ui/events/event.h > File ui/events/event.h (right): > > https://codereview.chromium.org/1989623002/diff/280001/ui/events/event.h#newcode1089 > ui/events/event.h:1089: uint32_t unique_touch_event_id_; > On ...
4 years, 6 months ago (2016-06-09 17:22:14 UTC) #56
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989623002/320001
4 years, 6 months ago (2016-06-09 17:30:40 UTC) #59
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/226232)
4 years, 6 months ago (2016-06-09 18:22:34 UTC) #62
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989623002/340001
4 years, 6 months ago (2016-06-09 19:41:55 UTC) #65
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/236577)
4 years, 6 months ago (2016-06-09 22:45:46 UTC) #67
mustaq
Discovered that the Windows test failure is caused by the change in EventSender::GetMovedBeyondSlopRegionArg(). Still investigating ...
4 years, 6 months ago (2016-06-15 15:53:00 UTC) #68
mustaq
On 2016/06/15 15:53:00, mustaq wrote: > Discovered that the Windows test failure is caused by ...
4 years, 6 months ago (2016-06-15 17:32:14 UTC) #69
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989623002/400001
4 years, 6 months ago (2016-06-15 17:37:51 UTC) #72
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/201171)
4 years, 6 months ago (2016-06-15 17:47:31 UTC) #74
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989623002/420001
4 years, 6 months ago (2016-06-15 18:46:50 UTC) #77
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/239614)
4 years, 6 months ago (2016-06-15 21:29:19 UTC) #79
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989623002/420001
4 years, 6 months ago (2016-06-16 15:32:45 UTC) #81
commit-bot: I haz the power
Committed patchset #21 (id:420001)
4 years, 6 months ago (2016-06-16 21:39:48 UTC) #83
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 21:43:38 UTC) #85
Message was sent while issue was closed.
Patchset 21 (id:??) landed as
https://crrev.com/1904837ebb6f8f352572e0f833e14640a0db6d54
Cr-Commit-Position: refs/heads/master@{#400264}

Powered by Google App Engine
This is Rietveld 408576698